Skip to content

Create a draft PR for cloud chemistry module #1

@mattldawson

Description

@mattldawson

Issue Type

Code Clean-up

Issue Description

Create a draft pull request for cloud chemistry so that the code can be reviewed.

Ideas

  • duplicate the existing here, here, here
  • rename the modules to cloud_aqueous_chemistry, mam_clouds, carma_clouds, with corresponding file names
  • start from the Francis's development branch
  • things to consider in review
    • missing descriptions for units for variables
    • missing descriptions of functions and function arguments
    • unused variables
    • cryptically named variables
    • dead code blocks
    • potential to break up large code blocks, and introduce reusable/testable functions
    • compare MAM and CARMA code for consistency
    • identify host-model vs aerosol-model portions of the code
    • separate configuration data from algorithms
    • magic numbers

Will this change answers?

Yes

Will you be implementing this yourself?

Yes

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions