Skip to content

Remove query_id from NodeBinding #516

@colleenXu

Description

@colleenXu

This issue is for discussing the removal of query_id from NodeBinding (formal deprecation).

Currently, some members are in favor of removal, recalling...

  • in the past, query_id was used for QNode ID subclassing cases: the NodeBinding's query_id would be the original QNode ID, while the the id would be descendant Node that's actually used in the Result.
  • that behavior has been replaced by using AuxGraphs: the NodeBinding id is to the QNode ID, and the edge has a support_graph (AuxGraph) with the subclassing edges/descendant Node that's actually used
  • so the query_id isn't used for anything

Other members want more discussion, recalling...

  • query_id is used for set-input queries?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions