Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the external mock dependency in favor of the built-in unittest.mock module, which has been available since Python 3.3. The change reduces external dependencies and modernizes the test infrastructure.
- Updated
tests/python/requirements-dev.txtto remove themockpackage - Changed the import statement in
tests/python/operator_test.pyfromimport mocktofrom unittest import mock
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/python/requirements-dev.txt | Removed the external mock dependency (note: also includes an unrelated commented dm3_lib line) |
| tests/python/operator_test.py | Updated import statement to use unittest.mock instead of the external mock package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
celiafish
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an unnecessary external dependency on 'mock'. It now uses unittest.mock instead.