Tylera/gtc 2025 tutorials by cliffburdick · Pull Request #900 · NVIDIA/MatX

cliffburdick · 2025-03-05T18:59:45Z

No description provided.

…ials

…a/gtc_2025_tutorials

…ials

…custom scalar_ops function

…to tylera/gtc_2025_tutorials

copy-pr-bot · 2026-01-26T23:02:51Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

cliffburdick · 2026-01-26T23:03:32Z

/build

greptile-apps · 2026-01-26T23:07:00Z

Greptile Overview

Greptile Summary

This PR adds comprehensive GTC 2025 tutorial materials for MatX, including three new lab notebooks covering introduction, kernel fusion, and profiling topics. The changes reorganize the tutorial structure to support in-notebook execution via a new IPython extension (run_matx.py) that compiles and runs MatX code directly in Jupyter cells.

Major Changes

New Tutorial Infrastructure: Added run_matx.py IPython extension enabling inline MatX code execution in notebooks with compilation progress indicators
GTC Lab Notebooks: Created three tutorial notebooks (01_lab_intro.ipynb, 02_lab_fusion.ipynb, 03_lab_profiling.ipynb) with exercises and solutions
Sample Programs: Added kernel_fusion.cu and simple_radar_pipeline.cu examples demonstrating NVTX profiling and performance optimization
Docker Updates: Modified lab.Dockerfile to use internal GitLab base image and reorganized setup steps
Exercise Cleanup: Removed 35 standalone exercise files, consolidating exercises into notebooks

Issues Found

Critical: Both kernel_fusion.cu files contain duplicate MATX_EXIT_HANDLER() calls (lines 44-45) that will cause double-cleanup
Repository Hygiene: Compiled binaries (10MB total) and .nsys-rep files committed to git should be generated during setup instead
Docker Image: Using internal NVIDIA GitLab registry instead of public image may limit external usability

The tutorial content is well-structured with clear progression from basics to advanced topics, comprehensive NVTX instrumentation for profiling, and practical radar signal processing examples.

Confidence Score: 3/5

Safe to merge after fixing duplicate MATX_EXIT_HANDLER() calls in kernel_fusion.cu files
Score reflects one critical syntax error (duplicate exit handler) that must be fixed, plus repository hygiene concerns about committed binaries that should ideally be addressed
kernel_fusion.cu files require immediate fixes for duplicate MATX_EXIT_HANDLER() calls; consider removing compiled binaries from git

Important Files Changed

Filename	Overview
docs_input/notebooks/gtc_lab/samples/kernel_fusion.cu	Example demonstrating kernel fusion with NVTX markers - has duplicate MATX_EXIT_HANDLER() call
examples/kernel_fusion.cu	Added kernel fusion example - has duplicate MATX_EXIT_HANDLER() call
docker/dli_lab/lab.Dockerfile	Updated to use internal GitLab base image and reorganized installation steps
docs_input/notebooks/gtc_lab/samples/simple_radar_pipeline.cu	New radar pipeline example with multi-stage processing and NVTX profiling
docs_input/notebooks/scripts/run_matx.py	New IPython extension for compiling and running MatX code in Jupyter notebooks

Sequence Diagram

sequenceDiagram
    participant User
    participant JupyterNotebook
    participant RunMatxExtension
    participant NVCC
    participant CompiledBinary
    participant GPU

    User->>JupyterNotebook: Start GTC Lab Tutorial
    JupyterNotebook->>User: Load 01_lab_intro.ipynb
    
    User->>JupyterNotebook: Execute %%run_matx cell
    JupyterNotebook->>RunMatxExtension: Pass MatX code
    RunMatxExtension->>RunMatxExtension: Wrap code in main()
    RunMatxExtension->>RunMatxExtension: Write to /tmp/output.cu
    RunMatxExtension->>NVCC: Compile with nvcc
    NVCC->>CompiledBinary: Generate /tmp/output
    CompiledBinary->>GPU: Execute on GPU
    GPU->>CompiledBinary: Return results
    CompiledBinary->>RunMatxExtension: stdout/stderr
    RunMatxExtension->>JupyterNotebook: Display output
    JupyterNotebook->>User: Show results
    
    User->>JupyterNotebook: Progress to 02_lab_fusion.ipynb
    User->>JupyterNotebook: Run kernel_fusion sample
    JupyterNotebook->>CompiledBinary: Execute pre-built binary
    CompiledBinary->>GPU: Run unfused kernels
    GPU->>CompiledBinary: Measure performance
    CompiledBinary->>GPU: Run fused operation
    GPU->>CompiledBinary: Measure performance
    CompiledBinary->>User: Compare results
    
    User->>JupyterNotebook: Progress to 03_lab_profiling.ipynb
    User->>JupyterNotebook: Profile simple_radar_pipeline
    JupyterNotebook->>CompiledBinary: Run with NVTX markers
    CompiledBinary->>GPU: Execute radar pipeline stages
    Note over CompiledBinary,GPU: PulseCompression<br/>ThreePulseCanceller<br/>DopplerProcessing<br/>CFARDetections
    GPU->>CompiledBinary: Performance data
    CompiledBinary->>User: Display profiling results

greptile-apps

_{4 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

docker/dli_lab/lab.Dockerfile

docs_input/notebooks/01_introduction.ipynb

docs_input/notebooks/gtc_lab/samples/simple_radar_pipeline.cu

docs_input/notebooks/01_introduction.ipynb

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps

_{4 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

docs_input/notebooks/gtc_lab/samples/kernel_fusion.cu

examples/kernel_fusion.cu

greptile-apps · 2026-01-27T19:07:40Z

Additional Comments (2)

docs_input/notebooks/gtc_lab/samples/kernel_fusion
compiled binary executable (~2.5 MB) committed - add to .gitignore and remove from repo

docs_input/notebooks/gtc_lab/samples/simple_radar_pipeline
compiled binary executable (~7.6 MB) committed - add to .gitignore and remove from repo

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps

_{6 files reviewed, 6 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-27T19:13:24Z

docs_input/notebooks/gtc_lab/samples/kernel_fusion.cu

+  MATX_EXIT_HANDLER();
+  MATX_EXIT_HANDLER();


duplicate MATX_EXIT_HANDLER() call on lines 44-45

Suggested change

MATX_EXIT_HANDLER();

MATX_EXIT_HANDLER();

MATX_EXIT_HANDLER();

}

greptile-apps · 2026-01-27T19:13:25Z

examples/kernel_fusion.cu

+  MATX_EXIT_HANDLER();
+  MATX_EXIT_HANDLER();


duplicate MATX_EXIT_HANDLER() call on lines 44-45

Suggested change

MATX_EXIT_HANDLER();

MATX_EXIT_HANDLER();

MATX_EXIT_HANDLER();

}

greptile-apps · 2026-01-27T19:13:26Z

docker/dli_lab/lab.Dockerfile

-
-
+#FROM ghcr.io/nvidia/matx/production:latest AS devel
+FROM gitlab-master.nvidia.com:5005/devtech-compute/sigx-group/container/build:12.8_x86_64_ubuntu22.04-amd64 AS devel


using internal NVIDIA GitLab registry instead of public image - verify this is intended for external use

greptile-apps · 2026-01-27T19:13:34Z

docs_input/notebooks/scripts/run_matx.py

+    stderr_thread.join()
+    stdout_thread.join()
+
+    cur_line = 0  


resetting cur_line = 0 after process completion has no effect - this variable goes out of scope immediately after

greptile-apps · 2026-01-27T19:13:37Z

Additional Comments (2)

docs_input/notebooks/gtc_lab/samples/kernel_fusion
committing compiled binary (2.4M) to git - these should typically be built during setup, not committed to version control

docs_input/notebooks/gtc_lab/samples/simple_radar_pipeline
committing compiled binary (7.3M) to git - these should typically be built during setup, not committed to version control

tylera-nvidia and others added 30 commits January 24, 2025 05:57

moving all 01 introduction tutorials to inlined examples

e590290

move notebook 2 to cell execution. run is currently broken

f7b6717

updated transforms notebook to use cell based execution

bbb37a9

adding script for notebook. has hardcoded paths

6903ac4

adding empty notebooks for fusion/profiling

7825f95

Adding timing metrics to CUDA and host executors

fb8e89a

Fixed docs

c47e4b3

details added to notebook 1

82d5846

adding incomplete books

c695d5a

update profiling lab with content explaining API

9fa6c81

Merge branch 'timing' into tylera/gtc_2025_tutorials

9150c90

adding exec to all runs

e57459d

Merge remote-tracking branch 'origin/main' into tylera/gtc_2025_tutor…

5b19014

…ials

moving notebook to remove radar

e5d5a70

cleanup

585e5e6

Initialize host cuRAND API when using host compiler

ba0651b

Merge remote-tracking branch 'origin/cliffburdick-patch-2' into tyler…

148c138

…a/gtc_2025_tutorials

Merge remote-tracking branch 'origin/main' into tylera/gtc_2025_tutor…

20c8104

…ials

updates for cleaning up and testing random fixes

c6de2ba

Merge remote-tracking branch 'origin/main' into tylera/gtc_2025_tutor…

2fd6368

…ials

cleanup for notebook1

a52cf7c

removing checked in cell results

006b8b5

cleanup comments on notebook1

9b0a832

updates to better automate run script. fix for normcdf

bf826bc

removing custom function for now

794865c

updates for limitations section of fusion. mount entire scratch. and …

c2a0534

…custom scalar_ops function

remove output for notebook 2

4fc9800

cleanup

d3e204c

redefinition fix

99e7cdb

Fix URL to creating tensors docs

a1428b1

tylera-nvidia and others added 15 commits March 7, 2025 15:35

update to new magic command in notebook 2

fd35b43

clearing run cells

4015210

Added solutions

84921d7

Update 01_lab_intro.ipynb

219f2f9

updates to move solutions

43faa76

Merge branch 'tylera/gtc_2025_tutorials' of github.com:NVIDIA/MatX in…

e57979a

…to tylera/gtc_2025_tutorials

fixing markdown

a8a4c4d

Add cout line to indicate cell has compiled and run

e3f2262

Updates to 03_lab_profiling.ipynb

5a84d77

Add backup Nsight reports

3da6773

Add img files

6bd96d6

updates for language on fusion limitations

2ddcf9e

Update 01_lab_intro.ipynb

3d8d33d

Update 01_C.ipynb

c33a590

Merge branch 'main' into tylera/gtc_2025_tutorials

c37e247

greptile-apps bot reviewed Jan 26, 2026

View reviewed changes

cliffburdick and others added 3 commits January 27, 2026 11:02

Fix Dockerfile build command for MatX

6a3ac2f

Update docs_input/notebooks/01_introduction.ipynb

33c8d2d

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update docs_input/notebooks/gtc_lab/samples/simple_radar_pipeline.cu

6d04c5a

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps bot reviewed Jan 27, 2026

View reviewed changes

docs_input/notebooks/gtc_lab/samples/kernel_fusion.cu Show resolved Hide resolved

examples/kernel_fusion.cu Show resolved Hide resolved

cliffburdick and others added 2 commits January 27, 2026 11:08

Update docs_input/notebooks/gtc_lab/samples/kernel_fusion.cu

853bf19

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update examples/kernel_fusion.cu

7a70039

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

cliffburdick merged commit 33ccb68 into main Jan 27, 2026

cliffburdick deleted the tylera/gtc_2025_tutorials branch January 27, 2026 19:09

greptile-apps bot reviewed Jan 27, 2026

View reviewed changes



		#FROM ghcr.io/nvidia/matx/production:latest AS devel
		FROM gitlab-master.nvidia.com:5005/devtech-compute/sigx-group/container/build:12.8_x86_64_ubuntu22.04-amd64 AS devel

Conversation

cliffburdick commented Mar 5, 2025

Uh oh!

copy-pr-bot bot commented Jan 26, 2026

Uh oh!

cliffburdick commented Jan 26, 2026

Uh oh!

greptile-apps bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Major Changes

Issues Found

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Jan 27, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps bot commented Jan 26, 2026 •

edited

Loading