Skip to content

Commit bc08155

Browse files
committed
Rename field model_config to model_cfg in NIXLKVBench workload
1 parent caa903c commit bc08155

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/cloudai/workloads/nixl_kvbench/nixl_kvbench.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from __future__ import annotations
1818

19-
from typing import Literal
19+
from typing import Literal, Union
2020

2121
from cloudai.core import CmdArgs, DockerImage, Installable, JobStatusResult, TestDefinition, TestRun
2222
from cloudai.workloads.common.nixl import extract_nixlbench_data
@@ -33,6 +33,12 @@ class NIXLKVBenchCmdArgs(CmdArgs):
3333
kvbench_script: str = "/workspace/nixl/benchmark/kvbench/main.py"
3434
python_executable: str = "python"
3535

36+
model_cfg: Union[str, list[str]] | None = None
37+
"""Path to model configuration file used by NIXL KVBench.
38+
39+
Renamed from `model_config` to avoid conflict with Pydantic's internal attribute name.
40+
"""
41+
3642
backend: str | list[str] | None = None
3743

3844

src/cloudai/workloads/nixl_kvbench/slurm_command_gen_strategy.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,12 @@ def gen_kvbench_command(self) -> list[str]:
6666
f"{self.tdef.cmd_args.kvbench_script}",
6767
self.tdef.cmd_args.command,
6868
]
69+
6970
for k, v in self.test_run.test.cmd_args_dict.items():
71+
# model_config should not be used as it is a reserved pydantic field name
72+
if k == "model_cfg":
73+
k = "model_config"
74+
7075
command.append(f"--{k} {v}")
7176

7277
command.append("--etcd_endpoints http://$NIXL_ETCD_ENDPOINTS")

0 commit comments

Comments
 (0)