Skip to content

fix: eliminate hardcoded command names(move to distroless) #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdesiniotis merged 1 commit into from
Jan 29, 2026
+1 −3
Merged

fix: eliminate hardcoded command names(move to distroless) #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions assets/state-cc-manager/0500_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ spec:
- name: nvidia-cc-manager
image: "FILLED BY THE OPERATOR"
imagePullPolicy: IfNotPresent
command: ["k8s-cc-manager"]
env:
- name: NODE_NAME
valueFrom:
Expand Down Expand Up @@ -56,7 +55,7 @@ spec:
lifecycle:
preStop:
exec:
command: ["/bin/sh", "-c", "rm -f /run/nvidia/validations/.cc-manager-ctr-ready"]
command: ["/bin/rm", "-f", "/run/nvidia/validations/.cc-manager-ctr-ready"]
Copy link
Member

@elezar elezar Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intended to be part of this PR? At the very least I would expect this to be a separate commit since it is not related to removing the hard-coded command names.

Copy link
Contributor Author

@jojimt jojimt Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is intended to be a part of this PR. The goal is to move to distroless which does not include the shell. This is also why we need the hardcoded names to be removed. I have updated the description and heading to mention this.

terminationGracePeriodSeconds: 30
volumes:
- name: host-sys
Expand Down
1 change: 0 additions & 1 deletion assets/state-sandbox-device-plugin/0500_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ spec:
- image: "FILLED BY THE OPERATOR"
imagePullPolicy: IfNotPresent
name: nvidia-sandbox-device-plugin-ctr
command: ["nvidia-kubevirt-gpu-device-plugin"]
securityContext:
privileged: true
volumeMounts:
Expand Down