Skip to content

fix: increase max HTTP header size to 32kb bytes across all environments #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborovsky merged 10 commits into from
Feb 2, 2026
Merged

fix: increase max HTTP header size to 32kb bytes across all environments #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4c2c1e
fix: increase max HTTP header size to 32kb bytes across all environments
aborovsky Jan 29, 2026
b2fb8d1
fix: remove NODE_OPTIONS override for max HTTP header size
aborovsky Jan 29, 2026
338a5a7
fix: remove NODE_OPTIONS override for max HTTP header size in test sc…
aborovsky Jan 30, 2026
46c36a7
fix: remove NODE_OPTIONS override for max HTTP header size in test sc…
aborovsky Feb 1, 2026
9b14286
fix: simplify npm wrapper
aborovsky Feb 1, 2026
c1e0bb8
Update npm_bin/bright-cli.js
aborovsky Feb 1, 2026
d036544
fix: remove debug logging for HTTP max header size
aborovsky Feb 1, 2026
f160b63
fix: remove unnecessary return statement and trailing newline in npm …
aborovsky Feb 1, 2026
d54fa64
fix: move max HTTP header size configuration from runtime to request …
aborovsky Feb 2, 2026
4f1be81
refactor: extract MAX_HEADERS_SIZE constant to RequestExecutorConstan…
aborovsky Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/RequestExecutor/HttpRequestExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { RequestExecutorOptions } from './RequestExecutorOptions';
import { NormalizeZlibDeflateTransformStream } from '../Utils/NormalizeZlibDeflateTransformStream';
import { CertificatesCache } from './CertificatesCache';
import { CertificatesResolver } from './CertificatesResolver';
import { RequestExecutorConstants } from './RequestExecutorConstants';
import { inject, injectable } from 'tsyringe';
import iconv from 'iconv-lite';
import { safeParse } from 'fast-content-type-parse';
Expand Down Expand Up @@ -218,7 +219,8 @@ export class HttpRequestExecutor implements RequestExecutor {
pfx: request.pfx,
passphrase: request.passphrase,
method: request.method,
rejectUnauthorized: false
rejectUnauthorized: false,
maxHeaderSize: RequestExecutorConstants.MAX_HEADERS_SIZE
};
}

Expand Down
3 changes: 3 additions & 0 deletions src/RequestExecutor/RequestExecutorConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export class RequestExecutorConstants {
public static readonly MAX_HEADERS_SIZE = 32768;
}
4 changes: 3 additions & 1 deletion src/RequestExecutor/WsRequestExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Helpers, logger, ProxyFactory } from '../Utils';
import { RequestExecutorOptions } from './RequestExecutorOptions';
import { CertificatesCache } from './CertificatesCache';
import { CertificatesResolver } from './CertificatesResolver';
import { RequestExecutorConstants } from './RequestExecutorConstants';
import { inject, injectable } from 'tsyringe';
import WebSocket from 'ws';
import { once } from 'node:events';
Expand Down Expand Up @@ -180,7 +181,8 @@ export class WsRequestExecutor implements RequestExecutor {
headers: this.normalizeHeaders(request.headers),
ca: request.ca,
pfx: request.pfx,
passphrase: request.passphrase
passphrase: request.passphrase,
maxHeaderSize: RequestExecutorConstants.MAX_HEADERS_SIZE
});

const res: IncomingMessage = await this.connect(client);
Expand Down
3 changes: 0 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
process.env.UV_THREADPOOL_SIZE = String(1024);
process.env.NODE_OPTIONS = `${
process.env.NODE_OPTIONS ?? ''
} --max-http-header-size=40960`.trim();
import 'reflect-metadata';
import {
PollingScanStatus,
Expand Down