[MIG] sale_operating_unit: Migration to 18.0

Author: BhaveshHeliconia

sale_operating_unit/README.rst

@@ -17,13 +17,13 @@ Operating Unit in Sales
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Foperating--unit-lightgray.png?logo=github
-    :target: https://github.com/OCA/operating-unit/tree/17.0/sale_operating_unit
+    :target: https://github.com/OCA/operating-unit/tree/18.0/sale_operating_unit
     :alt: OCA/operating-unit
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/operating-unit-17-0/operating-unit-17-0-sale_operating_unit
+    :target: https://translation.odoo-community.org/projects/operating-unit-18-0/operating-unit-18-0-sale_operating_unit
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/operating-unit&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/operating-unit&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -61,7 +61,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/operating-unit/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/operating-unit/issues/new?body=module:%20sale_operating_unit%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/operating-unit/issues/new?body=module:%20sale_operating_unit%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -77,15 +77,18 @@ Authors
 Contributors
 ------------
 
--  Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
--  Aaron Henriquez <ahforgeflow@forgeflow.com>
--  Lois Rilo <lois.rilo@forgeflow.com>
--  Miquel Raich <miquel.raich@forgeflow.com>
--  Sudhir Arya <sudhir.arya@serpentcs.com>
--  Darshan Patel <darshan.patel.serpencs@gmail.com>
--  Alan Ramos <alan.ramos@jarsa.com.mx>
--  Jorge Alberto Olvera Cuenca <jorge.olvera@jarsa.com>
--  Alejandro Padrón <alejandro.padron@bt-group.com>
+- Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
+- Aaron Henriquez <ahforgeflow@forgeflow.com>
+- Lois Rilo <lois.rilo@forgeflow.com>
+- Miquel Raich <miquel.raich@forgeflow.com>
+- Sudhir Arya <sudhir.arya@serpentcs.com>
+- Darshan Patel <darshan.patel.serpencs@gmail.com>
+- Alan Ramos <alan.ramos@jarsa.com.mx>
+- Jorge Alberto Olvera Cuenca <jorge.olvera@jarsa.com>
+- Alejandro Padrón <alejandro.padron@bt-group.com>
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
 
 Maintainers
 -----------
@@ -100,6 +103,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/operating-unit <https://github.com/OCA/operating-unit/tree/17.0/sale_operating_unit>`_ project on GitHub.
+This module is part of the `OCA/operating-unit <https://github.com/OCA/operating-unit/tree/18.0/sale_operating_unit>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_operating_unit/__manifest__.py

@@ -4,7 +4,7 @@
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
 {
     "name": "Operating Unit in Sales",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "summary": "An operating unit (OU) is an organizational entity part of a "
     "company",
     "author": "ForgeFlow, "

sale_operating_unit/models/crm_team.py

@@ -2,7 +2,7 @@
 # - Jordi Ballester Alomar
 # © 2019 Serpent Consulting Services Pvt. Ltd. - Sudhir Arya
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
-from odoo import SUPERUSER_ID, _, api, models
+from odoo import SUPERUSER_ID, api, models
 from odoo.exceptions import ValidationError
 
 
@@ -24,7 +24,7 @@ def _check_sales_order_operating_unit(self):
             )
             if orders:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "Configuration error. It is not "
                         "possible to change this "
                         "team. There are sale orders "

sale_operating_unit/models/sale_order.py

@@ -2,7 +2,7 @@
 # - Jordi Ballester Alomar
 # © 2019 Serpent Consulting Services Pvt. Ltd. - Sudhir Arya
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -68,7 +68,7 @@ def _check_team_operating_unit(self):
         for rec in self:
             if rec.team_id and rec.team_id.operating_unit_id != rec.operating_unit_id:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "Configuration error. The Operating "
                         "Unit of the sales team must match "
                         "with that of the quote/sales order."

sale_operating_unit/readme/CONTRIBUTORS.md

@@ -7,3 +7,5 @@
 - Alan Ramos \<<alan.ramos@jarsa.com.mx>\>
 - Jorge Alberto Olvera Cuenca \<<jorge.olvera@jarsa.com>\>
 - Alejandro Padrón \<<alejandro.padron@bt-group.com>\>
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia

sale_operating_unit/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Operating Unit in Sales</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:3213285322c7ae5f333caf42c36bbbef3b229f3235f1c7062918e291a63cc81a
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/operating-unit/tree/17.0/sale_operating_unit"><img alt="OCA/operating-unit" src="https://img.shields.io/badge/github-OCA%2Foperating--unit-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/operating-unit-17-0/operating-unit-17-0-sale_operating_unit"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/operating-unit&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/operating-unit/tree/18.0/sale_operating_unit"><img alt="OCA/operating-unit" src="https://img.shields.io/badge/github-OCA%2Foperating--unit-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/operating-unit-18-0/operating-unit-18-0-sale_operating_unit"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/operating-unit&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module extends the Sales capabilities of Odoo and introduces the
 operating unit to the Sales Order. Security rules are defined to ensure
 that users can only display the Sales Orders in which they are allowed
@@ -409,7 +409,7 @@ <h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/operating-unit/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/operating-unit/issues/new?body=module:%20sale_operating_unit%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/operating-unit/issues/new?body=module:%20sale_operating_unit%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -433,6 +433,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Alan Ramos &lt;<a class="reference external" href="mailto:alan.ramos&#64;jarsa.com.mx">alan.ramos&#64;jarsa.com.mx</a>&gt;</li>
 <li>Jorge Alberto Olvera Cuenca &lt;<a class="reference external" href="mailto:jorge.olvera&#64;jarsa.com">jorge.olvera&#64;jarsa.com</a>&gt;</li>
 <li>Alejandro Padrón &lt;<a class="reference external" href="mailto:alejandro.padron&#64;bt-group.com">alejandro.padron&#64;bt-group.com</a>&gt;</li>
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -444,7 +448,7 @@ <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/operating-unit/tree/17.0/sale_operating_unit">OCA/operating-unit</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/operating-unit/tree/18.0/sale_operating_unit">OCA/operating-unit</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

sale_operating_unit/tests/test_sale_operating_unit.py

@@ -3,6 +3,7 @@
 # © 2019 Serpent Consulting Services Pvt. Ltd. - Sudhir Arya
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
+from odoo.exceptions import ValidationError
 from odoo.models import Command
 
 from odoo.addons.operating_unit.tests.common import OperatingUnitCommon
@@ -83,7 +84,11 @@ def _create_sale_team(cls, uid, operating_unit):
             cls.sale_team_model.with_user(uid)
             .with_context(mail_create_nosubscribe=True)
             .create(
-                {"name": operating_unit.name, "operating_unit_id": operating_unit.id}
+                {
+                    "name": operating_unit.name,
+                    "operating_unit_id": operating_unit.id,
+                    "company_id": operating_unit.company_id.id,
+                }
             )
         )
         return team
@@ -166,3 +171,49 @@ def test_security_2(self):
         self.assertEqual(
             len(sale.ids), 1, f"User 1 should have access to OU {self.b2c.name}"
         )
+
+    def test_check_sales_order_operating_unit(self):
+        """Test that changing the operating unit of a sales team
+        with existing sale orders raises an error."""
+        with self.assertRaises(ValidationError):
+            self.sale_team_ou1.operating_unit_id = self.b2c.id
+
+    def test_compute_operating_unit_id(self):
+        """Test that changing the sales team updates the
+        operating unit in sale order."""
+        sale_order = self.sale_model.create(
+            {
+                "partner_id": self.customer.id,
+                "team_id": self.sale_team_ou1.id,
+            }
+        )
+        self.assertEqual(sale_order.operating_unit_id, self.ou1)
+        sale_order.team_id = self.sale_team_b2c.id
+        self.assertEqual(sale_order.operating_unit_id, self.b2c)
+
+    def test_compute_team_id(self):
+        """Test that sales team resets if its operating unit does not match."""
+        sale_order = self.sale_model.create(
+            {
+                "partner_id": self.customer.id,
+                "operating_unit_id": self.ou1.id,
+                "team_id": self.sale_team_ou1.id,
+            }
+        )
+        self.assertEqual(sale_order.team_id, self.sale_team_ou1)
+        sale_order.operating_unit_id = self.b2c.id
+        self.assertFalse(
+            sale_order.team_id, "Team should reset when operating unit mismatches"
+        )
+
+    def test_check_team_operating_unit_violation(self):
+        """Test that a ValidationError is raised when the team
+        and operating unit do not match."""
+        with self.assertRaises(ValidationError):
+            self.sale_model.create(
+                {
+                    "partner_id": self.customer.id,
+                    "operating_unit_id": self.ou1.id,
+                    "team_id": self.sale_team_b2c.id,
+                }
+            )

sale_operating_unit/views/sale_view.xml

@@ -47,11 +47,6 @@
                     groups="!operating_unit.group_multi_operating_unit"
                 />
             </field>
-            <field name="analytic_account_id" position="attributes">
-                <attribute
-                    name="domain"
-                >['|', ('company_id', '=', False), ('company_id', '=', company_id), "|",("operating_unit_ids","in", operating_unit_id),("operating_unit_ids","=", False)]</attribute>
-            </field>
             <field name="journal_id" position="attributes">
                 <attribute
                     name="domain"