From 1e9d18b38f5a6783b9f266b1e751a2ba5eb441db Mon Sep 17 00:00:00 2001
From: Aungkokolin1997 <lin@quartile.co>
Date: Mon, 15 Dec 2025 02:25:28 +0000
Subject: [PATCH] [IMP] web_form_banner: adj to resolve eslint warnings

---
 .../static/src/js/web_form_banner.esm.js      | 40 +++++++++++++------
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/web_form_banner/static/src/js/web_form_banner.esm.js b/web_form_banner/static/src/js/web_form_banner.esm.js
index c51144cd2476..8cc076082afc 100644
--- a/web_form_banner/static/src/js/web_form_banner.esm.js
+++ b/web_form_banner/static/src/js/web_form_banner.esm.js
@@ -1,17 +1,18 @@
-/** @odoo-module **/
 // Copyright 2025 Quartile (https://www.quartile.co)
 // License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-import {patch} from "@web/core/utils/patch";
 import {onMounted, onWillUnmount} from "@odoo/owl";
 import {FormController} from "@web/views/form/form_controller";
 import {Record} from "@web/model/relational_model/record";
+import {patch} from "@web/core/utils/patch";
 
 const recRoot = (c) => (c && c.model && c.model.root) || null;
 const childSpan = (el) => {
     try {
         return (el && el.querySelector(":scope > span")) || null;
-    } catch {}
+    } catch {
+        // Ignore
+    }
     const f = el && el.firstElementChild;
     return f && f.tagName === "SPAN" ? f : null;
 };
@@ -22,22 +23,30 @@ const setHtml = (el, html) => {
 const safe = async (fn, fb) => {
     try {
         return await fn();
-    } catch {}
+    } catch {
+        // Ignore
+    }
     return fb;
 };
 
 function normalizeValue(v) {
-    if (v === null || v === undefined) return v; // Null/undefined
+    // Null/undefined
+    if (v === null || v === undefined) return v;
     const t = typeof v;
     if (t === "string" || t === "number" || t === "boolean") return v;
     if (Array.isArray(v))
-        return v.length === 2 && typeof v[1] === "string" ? v[0] : [...v]; // M2o id or cloned m2m ids
+        // M2o id or cloned m2m ids
+        return v.length === 2 && typeof v[1] === "string" ? v[0] : [...v];
     if (t === "object") {
-        if (typeof v.res_id === "number") return v.res_id; // M2o snapshot
-        if (typeof v.id === "number") return v.id; // M2o env
-        if (Array.isArray(v._currentIds)) return [...v._currentIds]; // M2m
+        // M2o snapshot
+        if (typeof v.res_id === "number") return v.res_id;
+        // M2o env
+        if (typeof v.id === "number") return v.id;
+        // M2m
+        if (Array.isArray(v._currentIds)) return [...v._currentIds];
     }
-    return undefined; // Ignore others (e.g., command lists)
+    // Ignore others (e.g., command lists)
+    return undefined;
 }
 function shrink(data) {
     const out = {};
@@ -77,7 +86,7 @@ async function refreshBanners(ctrl, extraChanges) {
     if (!nodes.length) return;
     const snap = {...shrink(rec.data), ...shrink(extraChanges)};
     const names = triggerNames(ctrl);
-    const vals = !rec.resId ? snap : names.length ? sliceBy(snap, names) : {};
+    const vals = rec.resId ? (names.length ? sliceBy(snap, names) : {}) : snap;
     const orm = ctrl.env.services.orm;
     for (const el of nodes) {
         const ruleId = parseInt(el.dataset.ruleId, 10);
@@ -98,7 +107,10 @@ async function refreshBanners(ctrl, extraChanges) {
 function scheduleRefresh(ctrl) {
     if (ctrl.__wfbSched) return;
     ctrl.__wfbSched = true;
-    requestAnimationFrame(() => ((ctrl.__wfbSched = false), refreshBanners(ctrl)));
+    requestAnimationFrame(() => {
+        ctrl.__wfbSched = false;
+        refreshBanners(ctrl);
+    });
 }
 
 function tick(ctrl) {
@@ -164,7 +176,9 @@ patch(Record.prototype, {
                 const ctrl = this.model.__controller;
                 if (ctrl) tick(ctrl);
             }
-        } catch {}
+        } catch {
+            // Ignore
+        }
         return res;
     },
 });