From f95be6012717dfda6128c3647c584a64e7a7a876 Mon Sep 17 00:00:00 2001 From: Lena MONTENOT Date: Tue, 16 Dec 2025 11:58:06 +0100 Subject: [PATCH] [FIX] web_group_by_percentage: Added exclusion of non-field columns In some list/tree views, there are non-field columns, for instance buttons to handle an action on a group of lines. Consequently, with this module installed, it's impossible to group lines in certain views, if the grouped view has a button, as using isNumericColumn, which tries to access the column in the view's fields, throws an Exception. As such, we exclude non-field columns from the computation of grouped columns percentages. --- web_group_by_percentage/static/src/js/backend.esm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_group_by_percentage/static/src/js/backend.esm.js b/web_group_by_percentage/static/src/js/backend.esm.js index 8544b96d8d66..2268e8b15cd8 100644 --- a/web_group_by_percentage/static/src/js/backend.esm.js +++ b/web_group_by_percentage/static/src/js/backend.esm.js @@ -18,7 +18,7 @@ patch(ListRenderer.prototype, "list_group_by_percentage", { if (list.isGrouped) { for (var column of columns) { - if (!this.isNumericColumn(column)) continue; + if (column.type != "field" || !this.isNumericColumn(column)) continue; column.totalSum = 0; for (var group of list.groups) {