-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Description
In recent versions of SqlRender it is allowed to put your OhdsiSql in the inst/sql folder instead of the inst/sql/sql_server folder, and loadRenderTranslateSql() will still work. The main reasons are
- Techincally, it's OhdsiSql, not SQL Server SQL,
- Looks prettier.
- SqlRender has proven to be very capable of handling cross-platform idiosyncrasies, so most (if not all) packages have no need for platform-specific SQL.
(Note that plafform-specific code can still be placed in the appropriately named subfolders. It is just that 99.9% of SQL is OhdsiSql, so why not put it up a level?)
Currently ResultModelManager throw an error if I put the 'migrations' folder in the 'sql' folder. A simple extra lookup when looking for migration SQL would solve this. Could this be added?
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request