Should isRequired be a required filed in the model spec csv?

[chrisknoll]

See:

ResultModelManager/R/DataModel.R

Line 774 in ad706b4

requiredFields <- c("tableName", "columnName", "dataType", "primaryKey")

isRequired (I'm assuming this defines nullable columns) is not a required field of the model spec. Should it be?

[azimov]

Is required is not required - personally I would like to remove away from data models having required or not required fields. It adds complexity for the advantage of saving a few bytes. I'm also not sure any packages are currently using it and it is perfectly valid to have null fields within the database. We can review this prior to a 1.0.0 release

[chrisknoll]

Ok, that's fair and as author of RMM your prerogative, but, it does raise the question about how to specify that a column should be NULL-able in the DDL when it calls generateSqlSchema.

[azimov]

Personally I dislike the use of this function (I think writing SQL is explicit, and we already have a translation layer to other languages) but it was added as a convenience because strategus modules need to upload results to something.