codeserver 3.11.0 broken

[johrstrom]

It appears that the problem described in in #2 (comment) is again occurring with bc_osc_codeserver 0.4.0 and code-server >= 3.11.0 (but 3.10.2 works OK)

Originally posted by @nathanweeks in #2 (comment)

[orbsmiv]

Further to this I'm attempting to update our OnDemand Code Server app to use version 4.2.0, which has undergone a fairly substantial refactoring to bring it inline with some upstream VS Code changes. They've also changed some of the Cookie handling, as outlined in the following issue:

coder/code-server#4691 (comment)

I've not looked in detail but the following PR may be significant:
coder/code-server#4548

[johrstrom]

I also just patched OnDemand with the PR below for an entirely separate reason. But it may catch relative URLs better.

OSC/ondemand#1934

Another route would be to set the app up as /node instead of /rnode, though I don't know if it's possible.

[dgtim]

The auth problem persists while trying the server version 4.7.0. Launching like code-server --auth="password" ... with the PASSWORD set brings us to the login screen with

"Welcome to code-server
Please log in below. Password was set from $PASSWORD."

and a password submit field.

[CALMorACT]

This problem can be solved by changing the method of mocking cookie.

code-server has changed the hash algorism of cookie from the 3.11.0.
The new algorism is argon2, so the additional ruby package ruby-argon2 need to added in dashboard. (I don' t know how to add the additional package for interactive apps, but add it in dashboard app, it runs well)

[jaguillette]

The previous comment is correct in that it's necessary to change the hashing method for the cookie created in view.html.erb, but there's an alternative auth mechanism in view.html.erb. The auth mechanism that's conditionally used for code-server 4.8.3 works for >= 3.11 with the argon2 hashing algorithm. In our case I was able to change the 4.8.3 in view.html.erb to match the default version of code-server we set in our form.yml and auth in without a password prompt. If you can add the Ruby package for argon2 as the previous post suggests, you can make the cookie option work, but in our case the hidden form input alternative worked.

[KasperSkytte]

My solution was to use this form:

<form id="<%= form_id %>" action="/rnode/<%= host %>/<%= port %>/login?to=" method="post" target="_blank">
  <input type="hidden" name="password" value="<%= password %>">
  <button class="btn btn-primary" type="submit">
    <i class="fa fa-cogs"></i> Connect to Code Server
  </button>
</form>

Works with code-server version 4.23.1

[epruesse]

This no longer works. It has to be via cookie. Just using argon2 instead of digest does work. However, installing that argon2 gem into the bundle is a pain.