Forecasting: Principles and Practice, the Pythonic Way: LinearRegression() object library definition #64
Closed
KonstantinosTsoumas
started this conversation in
General
Replies: 1 comment 1 reply
-
|
Thanks @KonstantinosTsoumas for the suggestion. We will definitely try to make that part more clear. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Dear writers,
Let me use the first main sentence to express my gratitude for your work and keeping it this resource widely available to the general public.
A small detail in Chapter 5 of FPPPY, specifically section 5.1, may help others avoid some early confusion.
The example uses
LinearRegression()inside theSklearnModel()wrapper from statsforecast. In the book, thisLinearRegression()comes fromfpppy.models(also visible from the library imports found at the top of the page), but many readers may assume it refers to the scikit-learn version. Using scikit-learn’sLinearRegressionleads to an error, since it doesn’t include theadd_prediction_intervalsattribute.Proposal: A brief note in the text clarifying that
LinearRegression()comes fromfpppy.modelswould help readers avoid this confusion.Hopefully this note saves someone a bit of troubleshooting time!
Beta Was this translation helpful? Give feedback.
All reactions