-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
DB Issues
- It seems we are missing a lot of columns here. I'm literally only seeing
artworkbut from reading your user stories it seems you should have a few more tables, particularlyusers,galleries,gallery_contacts,artist_contacts, etc. - Your
userswill likely need a way to differentiate between their differentiate between their roles. For example, you may want to have booleans likeis_artistoris_gallery_ownerto signify whether or not they are an artist, a gallery owner, or both. - On your
artworksmodel (remember the convention is that this should be plural), I see you are adding columns for the artist information. Remember we shouldn't be doing this. An artwork instance should simply have anartist_idwhich points to an instance ofusersthat will contain all that information (name, etc.). Also, once we do that we can also probably eliminateartwork_*in the naming of the columns. - Overall, I feel like your database hasn't bee fully fleshed out yet. I want to take the time here to emphasize the CRIITICAL IMPORTANCE of having a well designed and thought out database, and hope you halt work on what you've started thus far and really put some effort into planning this part of your project.
Backend Routes Issues
- Theres a lot of columns that don't currently exist that I think we can agree probably should at this point, so clearly we should revisit this...
- Artwork has a delete route. Unless we are going to add a user story for someone being able to purchase a piece of art from the artist, this is probably not necessary.
Frontend Routes Issues
- Again a lot missing here so this is not very helpful to you yet. I would highly suggest putting some time into crafting these once you have a working model for your database and backend.
- Why is there a route for POST /artwork/:id ? Certainly this shouldn't exist right?
- Also, lets discuss why we should or would want to delete artwork....
Timeline Issues
- Timeline seems reasonably planned out. Good job!
Wireframes
-Looks good! Excited to see the finished product.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels