This repository was archived by the owner on Feb 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Update Liquidation #4
Open
dissimilllate
wants to merge
5
commits into
develop
Choose a base branch
from
chore/updateLiquidation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62b542c
feat: show liquidator profit in usd
dissimilllate 6a98aab
chore: show protocolSeizeShareMantissa
dissimilllate 44a41dd
chore: add comments
al-onyxprotocol d35598a
chore: show liquidation math
dissimilllate 233ca1b
chore: cleanup
dissimilllate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| module.exports = { | ||
| formatNumber(number) { | ||
| formatNumber(number, maximumFractionDigits = 20) { | ||
| return new Intl.NumberFormat('en-EN', { | ||
| maximumSignificantDigits: 21, | ||
| maximumFractionDigits, | ||
| }).format(number); | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,14 +51,17 @@ async function main() { | |
|
|
||
| // Get exchange rates for oXCN and XCN | ||
| const oXCNExchangeRate = await oXCN.callStatic.exchangeRateCurrent(); | ||
| console.log(`1 XCN in oXCN: ${formatNumber((1 / (oXCNExchangeRate / 1e28)))}`); | ||
| console.log(`1 oXCN in XCN: ${formatNumber(oXCNExchangeRate / 1e28)}`); | ||
| const oXCNExchangeRateUnscaled = oXCNExchangeRate / 1e28; | ||
| console.log(`1 XCN in oXCN: ${formatNumber((1 / oXCNExchangeRateUnscaled))}`); | ||
| console.log(`1 oXCN in XCN: ${formatNumber(oXCNExchangeRateUnscaled)}`); | ||
|
|
||
| // The percent, ranging from 0% to 100%, of a liquidatable account's borrow that can be repaid in a single liquidate transaction. | ||
| // https://docs.onyx.org/comptroller/close-factor | ||
| const closeFactorPercentage = (await Comptroller.callStatic.closeFactorMantissa() / 1e16) | ||
| const liquidationIncentiveMantissa = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e16); | ||
| const liquidationIncentiveCoefficient = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e18); | ||
| console.log('Close factor:', closeFactorPercentage, '%') | ||
| console.log('Liquidation incentive:', (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e16), '%') | ||
| console.log('Liquidation incentive:', liquidationIncentiveMantissa, '%') | ||
| console.log('\n'); | ||
|
|
||
| // Amount of XCN tokens at signer account | ||
|
|
@@ -71,6 +74,7 @@ async function main() { | |
| // Store balances and liquidity info before liquidation | ||
| summary.before.xcnBalance = await XCN.balanceOf(signerAddress); | ||
| summary.before.xcnLockedForSupply = await oXCN.callStatic.balanceOfUnderlying(signerAddress); | ||
| summary.before.liquidatorLiquidity = await Comptroller.getAccountLiquidity(signerAddress); | ||
| summary.before.borrowerLiquidity = await Comptroller.getAccountLiquidity(borrowerAddress); | ||
| summary.before.borrowerXcnLockedForSupply = await oXCN.callStatic.balanceOfUnderlying(borrowerAddress); | ||
| summary.before.borrowerXcnBalance = await oXCN.callStatic.borrowBalanceCurrent(borrowerAddress) | ||
|
|
@@ -116,6 +120,7 @@ async function main() { | |
|
|
||
| summary.after.xcnBalance = await XCN.balanceOf(signerAddress); | ||
| summary.after.xcnLockedForSupply = await oXCN.callStatic.balanceOfUnderlying(signerAddress); | ||
| summary.after.liquidatorLiquidity = await Comptroller.getAccountLiquidity(signerAddress); | ||
| summary.after.borrowerLiquidity = await Comptroller.getAccountLiquidity(borrowerAddress); | ||
| summary.after.borrowerXcnLockedForSupply = await oXCN.callStatic.balanceOfUnderlying(borrowerAddress); | ||
| summary.after.borrowerXcnBalance = await oXCN.callStatic.borrowBalanceCurrent(borrowerAddress) | ||
|
|
@@ -126,9 +131,32 @@ async function main() { | |
| console.log(`Borrower balance in XCN after liquidation: ${formatNumber(summary.after.borrowerXcnBalance / 1e18)}`); | ||
| console.log(`Borrower balance locked for supply in XCN: ${formatNumber(summary.after.borrowerXcnLockedForSupply / 1e18)}`); | ||
|
|
||
| const liquidatorProfit = (summary.after.xcnLockedForSupply - amountToRepay) / 1e18; | ||
| const protocolSeizeShareMantissa = await oXCN.protocolSeizeShareMantissa() / 1e16; | ||
| const protocolSeizeShareCoefficient = await oXCN.protocolSeizeShareMantissa() / 1e18; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using additional variable to keep formulas simple, because: In javascript: |
||
| const repayAmountWithIncentive = repayAmount / 1e18 * liquidationIncentiveCoefficient; | ||
| const protocolFee = repayAmountWithIncentive * protocolSeizeShareCoefficient; | ||
|
|
||
| console.log('\n'); | ||
| console.log(`Liquidator's profit: Repay amount * Liquidation incentive:`); | ||
| console.log(`${formatNumber(repayAmount / 1e18)} * ${formatNumber(liquidationIncentiveCoefficient)} = ${formatNumber(repayAmountWithIncentive)}`); | ||
| console.log(`Liquidator has to pay protocol fee: ${formatNumber(protocolSeizeShareMantissa)} % of Liqudidator's profit`); | ||
| console.log(`${formatNumber(protocolSeizeShareCoefficient)} * ${formatNumber(repayAmountWithIncentive)} = ${formatNumber(protocolFee)}`); | ||
| console.log(`Protocol fee + Liquidator's locked for supply income = Repay amount * Liquidation incentive = Borrower's locked for supply loss`); | ||
| console.log(`${formatNumber(protocolFee, 3)} + ${formatNumber((summary.after.xcnLockedForSupply - summary.before.xcnLockedForSupply) / 1e18, 3)} = ${formatNumber(repayAmount / 1e18, 3)} * ${formatNumber(liquidationIncentiveCoefficient)} = ${formatNumber((summary.before.borrowerXcnLockedForSupply - summary.after.borrowerXcnLockedForSupply) / 1e18, 3)}`); | ||
|
|
||
| // Calculate XCN rate based on current liquidity, XCN supply, and collateral factor | ||
| const liquidatorProfitXCN = (summary.after.xcnLockedForSupply - amountToRepay) / 1e18; | ||
| const collateralFactorXCN = (await Comptroller.callStatic.markets(oXCN.address))[1] / 1e18; | ||
| const xcnLockedForSupplyDiff = (summary.after.xcnLockedForSupply - summary.before.xcnLockedForSupply) / 1e18; | ||
| const borrowableXCN = xcnLockedForSupplyDiff * collateralFactorXCN; | ||
| const liquidityDiff = (summary.after.liquidatorLiquidity[1] - summary.before.liquidatorLiquidity[1]) / 1e18; | ||
| const calculatedXcnUsdRate = liquidityDiff / borrowableXCN; | ||
| const liquidatorProfitUSD = liquidatorProfitXCN * calculatedXcnUsdRate; | ||
|
|
||
| console.log('\n'); | ||
| console.log(`Liquidator profit in XCN (locked for supply - liquidation cost): ${formatNumber(liquidatorProfit)}`); | ||
| console.log('Calculated XCN rate:', calculatedXcnUsdRate); | ||
| console.log(`Liquidator profit in XCN (locked for supply - liquidation cost): ${formatNumber(liquidatorProfitXCN)}`); | ||
| console.log(`Liquidator approximate profit in USD: ${formatNumber(liquidatorProfitUSD)}`); | ||
| resolve(); | ||
| })); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using additional variable to keep formulas simple, because:
liquidationIncentiveCoefficient = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e16); // 110, whilst we need 1.1 for calculationsIn javascript:
1.1 / 1e2 = 0.011000000000000001