Revisit pool.destroy logic #1192
Description
The test destroy should close all child processes is flaky, so I've skipped it. Looking at the logic I'm not convinced it's doing what I think it's doing.
I don't that immediate exit is working properly. I would like to test this better and maybe refactor.
I'm not enjoying the killWorkerand waitForWorker to finish functions. I'd just like one killWorker function with optional timeout, which can be awaited.
A final cocern: looking back I'm confused about the difference between pool and allWorkers. Why do we need both? Something about workers coming out of the pool while active... I don't know.
I'd just like to revisit this later with a full brain,