total stake is not equal to sum of stakes

[botnumberseven]

Hi,
I've noticed some difference between othub.io numbers and staking page numbers. Specifically in total stake. So I'm trying to understand the source of the discrepancy. I'm using Neuro mainnet as an example here.

getTotalStake() from stakingStorage returns - 40252854488121289609688010. So 40,252,854.
I'm assuming that this value should be equal to the sum of stakes of all nodes on chain.
We have 216 identity_ids created. I ran getNodeStake() for all of them and it gave me this dictionary - stakes.txt

But if I just sum all the values here i get 40051209697591400000000000, which is 40,051,209. It's ~200k less than a total stake.

Is it a correct expectation to see totalStake being equal to sum of all nodes' stakes?

[botnumberseven]

@zsculac
I'm assuming you are the right person to advice here. @ you as I see none of my previous issues had any comments from the team, so not sure if anyone gets notifications for this repo tickets.

[zsculac]

@botnumberseven, your expectation is correct. The total stake should be equal to the sum of all nodes' stakes. Not exactly sure why there is a discrepancy, perhaps an accounting bug in previous contracts or during some migrations in the way totalStake was calculated. A more in-depth investigation would be required.

[zsculac]

For example, here:

dkg-evm-module/contracts/Staking.sol

Line 311 in 98867a5

ss.increaseTotalStake(delegatorWithdrawalAmount);

totalStake was increased by the delegatorWithdrawalAmount instead of returnableStakeAmount, resulting in a larger totalStake than it should.

[botnumberseven]

@zsculac I see, thank you.
I do not expect any actions here, just wanted to let you know.