Skip to content

🔄 synced file(s) with OrrisTech/.github #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamzifei merged 1 commit into from
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ concurrency:
jobs:
lint-typecheck:
name: Lint & Type Check
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
secrets: inherit

Expand All @@ -33,12 +36,13 @@ jobs:

build:
name: Build
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting continue-on-error: true combined with removing needs: [lint-typecheck] from the build job significantly weakens CI enforcement of code quality standards. The CI pipeline will now always pass even if there are linting or type-checking errors, and the build won't wait for lint checks to complete.

While the comment indicates this is temporary ("Remove continue-on-error once repo lint errors are resolved"), this approach allows technical debt to accumulate and makes it easy to forget to address underlying issues. Consider these alternatives:

  1. Fix existing lint errors in this repository first, then apply this sync
  2. Use GitHub's required status checks to make lint-typecheck "required" but allow bypassing with admin approval
  3. Add a time-bound issue or deadline to resolve lint errors and remove continue-on-error
  4. Keep the needs dependency to at least maintain the logical job order even if errors are allowed
Suggested change
name: Build
name: Build
needs: [lint-typecheck]

Copilot uses AI. Check for mistakes.
needs: [lint-typecheck]
uses: OrrisTech/.github/.github/workflows/ci-build.yml@main
secrets: inherit

security:
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
uses: OrrisTech/.github/.github/workflows/ci-security.yml@main
secrets: inherit

Expand Down