Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
853513b to
84889a7
Compare
React Doctor ReportClick to expand results
|
There was a problem hiding this comment.
Pull request overview
This PR syncs the repository’s thin CI caller workflow with the org-standard workflow definitions from OrrisTech/.github, updating how certain CI jobs are treated when they fail.
Changes:
- Removed
continue-on-error: truefrom thelint-typecheckjob. - Removed
continue-on-error: truefrom thesecurityjob. - Updated inline comments describing the intended impact of failures for those jobs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
28
| # Advisory only — does not block build or other jobs. | ||
| # Remove continue-on-error once repo lint errors are resolved. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main |
There was a problem hiding this comment.
These comments are misleading now that continue-on-error: true was removed. Even without needs:, a failing job will still make the overall workflow conclude as failed (and can block PR merge via required status checks). Either re-add continue-on-error: true to keep this advisory, or update/remove the “Advisory only” / “won't block CI” wording to reflect the new enforced behavior.
Comment on lines
43
to
45
| # Advisory only — does not block other jobs. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-security.yml@main |
There was a problem hiding this comment.
Same issue here: with continue-on-error removed, failures in this job will still fail the workflow even if other jobs don't need it. Please either restore continue-on-error: true to keep the “Advisory only” intent, or update the comments to reflect that this audit is now a required CI gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22212195514