Skip to content

🔄 synced file(s) with OrrisTech/.github #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamzifei merged 1 commit into from
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ jobs:
lint-typecheck:
name: Lint & Type Check
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
Comment on lines 26 to 28
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are inaccurate: even without needs, a failing job still makes the workflow run fail (and will block merges if this workflow is a required check). If the intent is truly “advisory only”, re-add continue-on-error: true; otherwise update/remove the “Advisory only / won’t block CI” wording to reflect that failures will fail the CI check.

Copilot uses AI. Check for mistakes.
secrets: inherit

Expand All @@ -42,7 +41,7 @@ jobs:
security:
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: removing continue-on-error: true means a security audit failure will fail the overall workflow run. The “advisory only / won’t block” comments should either be corrected, or continue-on-error: true should be restored if this job is intended to be non-blocking.

Suggested change
# No "needs:" from other jobs, so failures here won't block CI.
# No "needs:" from other jobs, so failures here won't block CI.
continue-on-error: true

Copilot uses AI. Check for mistakes.
uses: OrrisTech/.github/.github/workflows/ci-security.yml@main
secrets: inherit

Expand Down
Loading