Skip to content

Commit 6ce7627

Browse files
committed
Fixed metadata controllers returning tags, genres, publishers & developers for deleted games
1 parent a9e9e14 commit 6ce7627

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- Added ``TESTING_LOG_HTTP_TRAFFIC_ENABLED`` parameter to help analyze network traffic
1010
- Fixed ``early_access`` being required in UpdateGameDto inconsistency in OpenAPI contract
1111
- Fixed ``name`` not being mentioned in MetadataProviderDto inconsistency in OpenAPI contract
12+
- Fixed metadata controllers returning tags, genres, publishers & developers for deleted games
1213

1314

1415
### Thanks

src/modules/metadata/developers/developers.metadata.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class DeveloperController {
5050
): Promise<Paginated<DeveloperMetadata>> {
5151
const queryBuilder = this.developerRepository
5252
.createQueryBuilder("developer")
53-
.leftJoinAndSelect("developer.games", "games")
53+
.leftJoinAndSelect("developer.games", "games", "games.deleted_at IS NULL")
5454
.where("developer.provider_slug = :provider_slug", {
5555
provider_slug: "gamevault",
5656
})

src/modules/metadata/genres/genres.metadata.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class GenreController {
5050
): Promise<Paginated<GenreMetadata>> {
5151
const queryBuilder = this.genreRepository
5252
.createQueryBuilder("genre")
53-
.leftJoinAndSelect("genre.games", "games")
53+
.leftJoinAndSelect("genre.games", "games", "games.deleted_at IS NULL")
5454
.where("genre.provider_slug = :provider_slug", {
5555
provider_slug: "gamevault",
5656
})

src/modules/metadata/publishers/publishers.metadata.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class PublisherController {
5050
): Promise<Paginated<PublisherMetadata>> {
5151
const queryBuilder = this.publisherRepository
5252
.createQueryBuilder("publisher")
53-
.leftJoinAndSelect("publisher.games", "games")
53+
.leftJoinAndSelect("publisher.games", "games", "games.deleted_at IS NULL")
5454
.where("publisher.provider_slug = :provider_slug", {
5555
provider_slug: "gamevault",
5656
})

src/modules/metadata/tags/tags.metadata.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class TagsController {
5050
): Promise<Paginated<TagMetadata>> {
5151
const queryBuilder = this.tagRepository
5252
.createQueryBuilder("tag")
53-
.leftJoinAndSelect("tag.games", "games")
53+
.leftJoinAndSelect("tag.games", "games", "games.deleted_at IS NULL")
5454
.where("tag.provider_slug = :provider_slug", {
5555
provider_slug: "gamevault",
5656
})

0 commit comments

Comments
 (0)