C linting doesn’t work correctly

[clayrisser]

So, when I run npm run lint it fails. However when I copy/paste the clang-format command manually, it works. Is anyone else experiencing this same issue. Also, it seems C linting has not been run in ages, because it changes large portions of the code.

[Place1]

what's the error?

also, CI is supposed to run clang-format and fail builds if it doesn't pass. But I probably didn't set it up correctly :P

[ewnd9]

Error I see

$ yarn lint:c
yarn run v1.3.2
$ clang-format -i -style=file ./src/*.{h,cpp} ./src/**/*.{h,cpp}
No such file or directory
No such file or directory
error Command failed with exit code 1.

After removing the brackets, linting is working and showing errors:

-    "lint:c": "clang-format -i -style=file ./src/*.{h,cpp} ./src/**/*.{h,cpp}"
+    "lint:c": "clang-format -i -style=file ./src/*.h ./src/*.cpp ./src/**/*.h ./src/**/*cpp"

$ yarn lint:c
yarn run v1.3.2
$ clang-format -i -style=file ./src/*.h ./src/*.cpp ./src/**/*.h ./src/**/*cpp
YAML:39:23: error: unknown key 'SplitEmptyFunction'
  SplitEmptyFunction: tru
...

---

Also, CI doesn't check it right now, the command is defined only in the lint job which is missing in workflows

[Place1]

ahh. is that a zsh feature i accidentally made use of?

[clayrisser]

Oh odd, because I use zsh.

[ewnd9]

From a quick search I found that "NPM lifecycle uses sh -s to run commands on OS X/Linux and cmd /d /s /c on Windows." source

[Place1]

Ahh. That’s good to know. I’ll update the scripts and CI tonight (unless you wanted to make the PR 😀)

…

On Wed, 21 Feb 2018 at 8:58 am, ewnd9 ***@***.***> wrote: From a quick search I found that "NPM lifecycle uses sh -s to run commands on OS X/Linux and cmd /d /s /c on Windows." source ***@***.***/you-should-always-quote-your-globs-in-npm-scripts-621887a2a784> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALMBlhEm7TLDGigJn7Cb7JGb5DN49IAiks5tWz_1gaJpZM4SBLTT> .