From 39aab321d2a4a10f3c9d6d5a5630fe7235277787 Mon Sep 17 00:00:00 2001 From: Morne Alberts Date: Thu, 8 May 2025 12:07:39 +0200 Subject: [PATCH] Clarify join requirement --- src/Adapters/DatabasePersistentPageIdentifiersRepo.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Adapters/DatabasePersistentPageIdentifiersRepo.php b/src/Adapters/DatabasePersistentPageIdentifiersRepo.php index 207b916..90faa84 100644 --- a/src/Adapters/DatabasePersistentPageIdentifiersRepo.php +++ b/src/Adapters/DatabasePersistentPageIdentifiersRepo.php @@ -37,6 +37,7 @@ public function getPersistentIds( array $pageIds ): array { $result = $this->database->newSelectQueryBuilder() ->select( [ 'p.page_id', 'ppi.persistent_id' ] ) ->from( 'page', 'p' ) + // Join is necessary to exclude pages deleted from the `page` table, but not `persistent_page_ids`. ->leftJoin( 'persistent_page_ids', 'ppi', 'p.page_id = ppi.page_id' ) ->where( [ 'p.page_id' => $pageIds ] ) ->orderBy( 'p.page_id' )