Skip to content

v1.0.0 goals and considerations #2

@that-hatter

Description

@that-hatter

v1.0.0 will mark the version where every doc entry should have been manually looked over and consequently edited. The following are softer goals that may be decided or implemented along the way (they can be added in minor/patch bumps, not necessarily exactly on v1.0.0).

Finished Tasks
  • Add Github Actions for checking commits. If it's a doc edit, run the parser to validate it and output errors in the Action log.

  • Consider moving the typescript loader package to a different repo, making this only for the yaml files.

  • Figure out when exactly to run steps. Right now, the yaml files are part of the release build and are parsed/validated every time they're needed. Files from the ygocore and CardScripts repo are also fetched every time to add the source code links.
    These steps, especially the former, could be done before release by building a validated.json file and having the loader script use that if it exists. The npm run dump script partly does this already, but the dump file is mainly for quick local checking and not part of the release artifact.

  • Related to the previous two points, decide if the yaml files should be part of the semantic versioning. It would make sense for them to be if we decide to implement the validated.json file previously discussed.

  • Consider adding a toUnsafe/toNonStrict function that converts the output API object to a format that plays nicely without using fp-ts and the markdown module (e.g. everything is mutable, Option<T> is converted to T | null, markdown values are just plain strings).
    This is a very low priority goal, since I don't expect the typescript package to be used outside scrapi projects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions