Double request in the Patients List

[BogdanScherban]

@fzaninotto

Francois, could you please help me with this issue. I can't found a reason of double request in List-component:
https://drive.google.com/file/d/1qJkFUqUYNyjARSjCrUp2Mxgcrq2sQbZQ/view

You can see two problems:

1. In first case it run double request with "tweed";
2. In the second request in run double request with for previous search (tweed) and new search (smith)

How it works:

1. Patients List is empty by default;
2. User input patient lastname to the search field. This value saves in Store:
   
   
3. List re-render by this condition:
   

   PulseTile-RA/src/core/pages/PatientsList/templates/PatientListTemplate.js

   Line 414 in 43df121

   if (userSearch) {

   
   It increase key = key+1, and patients table refreshed.

Similar, it run request with previous value, and after this - run request with new value.

I don't understand how to prevent the first request.

[fzaninotto]

When you update the state based on the current state, you should use the function variant of setState (which you do) and use the state from the function parameters rather than from this (which you don't do):

    filterByUserSearch = () => {
        this.setState((state, props) => {
            if (state.filterText !== props.userSearch) {
                return {
                    filterText: props.userSearch,
-                   key: this.state.key + 1,
+                   key: state.key + 1,
                }
            }
        });
    };

I don't know if that's the cause of the problem but it might certainly cause bugs.

[fzaninotto]

You're changing the state in componentWillReceiveProps. That's an edge case that the React doc advises against (see https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops).

I ythink you should use componentDidUpdate instead.

[BogdanScherban]

@tony-shannon @fzaninotto

Thanks, Francois! The issue has been done!

[kuvakina]

@tony-shannon @PhilBarrett The issue with requests from the previous search in the new search was solved. Please see the video:
https://drive.google.com/file/d/1DdFPxhBYkGIWSlBWC4byDWyhbxXmHF09/view