diff --git a/solutions/prep_data.py b/solutions/prep_data.py index 58c415d..99c1750 100644 --- a/solutions/prep_data.py +++ b/solutions/prep_data.py @@ -15,7 +15,26 @@ print("- Extracting flight data... ", end='', flush=True) tar_path = os.path.join('data', 'nycflights.tar.gz') with tarfile.open(tar_path, mode='r:gz') as flights: - flights.extractall('data/') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(flights, "data/") print("done", flush=True) if not os.path.exists(jsondir):