Skip to content

We find that only the default warp_reduce is tested in test_device_reduce #773

@2021peace

Description

@2021peace

Describe the bug
In test_device_reduce, we know there are three reduce methods: warp_reduce, raking_reduce, and raking_reduce_commutative_only. We find that only the default warp_reduce is tested;

We know that we use DeviceReduceParamsList to build tests for other reduce methods, but when the TestFixture is configured with rakingreducing, the actual config will still be initialized to default reduce, which is also known as warp reduce;

You can see this logic from the source code:Lines 53 to 71 in the test_device_deduce.cpp file

To Reproduce
Steps to reproduce the behavior:
1.just install rocprim ,build the debug test, and run the_device_reduce;
2.Observe the actual configuration of config during testing, in line 191 of the test_deive_deduced file;

Expected behavior
Modify the writing of the test_device_deduction test template to enable it to test raking_reduce

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions