Outdated Forestry API causing crashes #1
Description
It's been reported in several locations, dating as far back as 2015 that the mod would crash with the error:
java.lang.AbstractMethodError: redgear.morebackpacks.backpacks.BackpackFarmer.isValidItem
replace BackpackFarmer with any other Backpack.
Nevertheless I went and forked this repository and made a quick fix:
https://github.com/Jonius7/MoreBackpacks/releases/tag/2.2.3
Issue was caused by Forestry API updating isValidItem to no longer have a PlayerEntity argument, so I removed it, as well as getName() no longer part of the API (and therefore @OverRide unnecessary)
Below is a more detailed log that I personally got. I don't know if there's any more bugs/instability out there but it seems to be fixed.
[16:21:59] [Server thread/ERROR]: Exception caught during firing event net.minecraftforge.event.entity.player.EntityItemPickupEvent@6e3cd2ab: java.lang.AbstractMethodError: redgear.morebackpacks.backpacks.BackpackFarmer.isValidItem(Lnet/minecraft/item/ItemStack;)Z at forestry.storage.PickupHandlerStorage.onItemPickup(PickupHandlerStorage.java:57) ~[PickupHandlerStorage.class:?] at forestry.core.EventHandlerCore.handleItemPickup(EventHandlerCore.java:47) ~[EventHandlerCore.class:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler_212_EventHandlerCore_handleItemPickup_EntityItemPickupEvent.invoke(.dynamic) ~[?:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:?] at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?] at net.minecraft.entity.item.EntityItem.func_70100_b_(EntityItem.java:345) ~[xk.class:?] at net.minecraft.entity.player.EntityPlayer.func_71044_o(EntityPlayer.java:609) ~[yz.class:?] at net.minecraft.entity.player.EntityPlayer.func_70636_d(EntityPlayer.java:600) ~[yz.class:?] at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:1611) ~[sv.class:?] at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:288) ~[yz.class:?] at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:295) ~[mw.class:?] at net.minecraft.network.NetHandlerPlayServer.func_147347_a(NetHandlerPlayServer.java:303) ~[nh.class:?] at net.minecraft.network.play.client.C03PacketPlayer.func_148833_a(SourceFile:137) ~[jd.class:?] at net.minecraft.network.play.client.C03PacketPlayer$C06PacketPlayerPosLook.func_148833_a(SourceFile:20) ~[jf.class:?] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) ~[ej.class:?] at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165) ~[nc.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659) ~[MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) ~[MinecraftServer.class:?] at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111) ~[bsx.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685) [?:?] [16:21:59] [Server thread/ERROR]: Index: 8 Listeners: [16:21:59] [Server thread/ERROR]: 0: HIGHEST [16:21:59] [Server thread/ERROR]: 1: ASM: abo.ImplicationEventHandler@2d42cb9e handleEntityItemPickupEvent(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 2: ASM: abo.CompressionEventHandler@38c9316 handleEntityItemPickupEvent(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 3: ASM: cofh.thermalfoundation.util.EventHandlerLexicon@1e1acd28 handleEntityItemPickupEvent(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 4: NORMAL [16:21:59] [Server thread/ERROR]: 5: ASM: net.p455w0rd.wirelesscraftingterminal.proxy.ClientProxy@36bce01 pickupEvent(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 6: ASM: am2.lore.CompendiumUnlockHandler@6f0f5c2f onPlayerPickupItem(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 7: ASM: ic2.core.IC2Achievements@73f8f221 onItemPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 8: ASM: forestry.core.EventHandlerCore@ac07419 handleItemPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 9: ASM: thaumcraft.common.lib.events.EventHandlerEntity@384d40df itemPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 10: ASM: vazkii.botania.common.item.ItemFlowerBag@5e548624 onPickupItem(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 11: ASM: factorization.common.Registry@e33f996 onItemPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)Z [16:21:59] [Server thread/ERROR]: 12: ASM: com.brandon3055.draconicevolution.common.achievements.Achievements@1f7cfb80 entityPickupEvent(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 13: ASM: enchiridion.EventsHandler@272b2cce onItemPickUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 14: ASM: joshie.enchiridion.library.handlers.BookObtainEvents@7e091827 onItemPickUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 15: ASM: openblocks.common.item.ItemDevNull@1ec1d04f onItemPickUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 16: ASM: pneumaticCraft.common.EventHandlerPneumaticCraft@440905a3 onPlayerPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 17: ASM: pneumaticCraft.common.EventHandlerUniversalSensor@21cb060 onItemPickUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 18: ASM: lumien.randomthings.Handler.RTEventHandler@568e433c itemPickUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 19: ASM: com.rwtema.extrautils.EventHandlerServer@5f854802 unstableIngotDestroyer(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 20: ASM: twilightforest.TFEventListener@2fe9db81 pickupItem(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 21: ASM: fox.spiteful.avaritia.LudicrousEvents@4edd5a12 clusterClustererererer(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 22: ASM: de.eydamos.backpack.handler.EventHandlerBackpack@515a311 playerPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 23: ASM: dany.toomanygoddamnores.Handler@7c6fe5d5 itemPickedUp(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 24: ASM: am2.AMEventHandler@41c7e499 onPlayerPickupItem(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 25: ASM: brad16840.backpacks.InventoryScanner@76c97e78 onPlayerPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 26: ASM: com.mjr.extraplanets.handlers.AchievementEventHandler@6d36f6bd onCraftingRockets(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 27: ASM: com.emoniph.witchery.ritual.rites.RitePriorIncarnation$EventHooks@6aaa109f onEntityItemPickup(Lnet/minecraftforge/event/entity/player/EntityItemPickupEvent;)V [16:21:59] [Server thread/ERROR]: 28: ASM: xreliquary.event.CommonEventHandler@4c65021d onEntityLiving(Lnet/minecraftforge/event/entity/living/LivingEvent;)V [16:21:59] [Server thread/ERROR]: 29: ASM: am2.ShrinkHandler@19f50d50 onEntityLiving(Lnet/minecraftforge/event/entity/living/LivingEvent;)V [16:21:59] [Client thread/INFO]: DRAGONAPI: Restoring furnace recipes to pre-Minetweaker state. Contains 1567 recipes (from 1567). [16:21:59] [Server thread/ERROR]: Encountered an unexpected exception net.minecraft.util.ReportedException: Ticking player at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181) ~[nc.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659) ~[MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) ~[MinecraftServer.class:?] at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111) ~[bsx.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685) [?:?] Caused by: java.lang.AbstractMethodError: redgear.morebackpacks.backpacks.BackpackFarmer.isValidItem(Lnet/minecraft/item/ItemStack;)Z at forestry.storage.PickupHandlerStorage.onItemPickup(PickupHandlerStorage.java:57) ~[PickupHandlerStorage.class:?] at forestry.core.EventHandlerCore.handleItemPickup(EventHandlerCore.java:47) ~[EventHandlerCore.class:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler_212_EventHandlerCore_handleItemPickup_EntityItemPickupEvent.invoke(.dynamic) ~[?:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:?] at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?] at net.minecraft.entity.item.EntityItem.func_70100_b_(EntityItem.java:345) ~[xk.class:?] at net.minecraft.entity.player.EntityPlayer.func_71044_o(EntityPlayer.java:609) ~[yz.class:?] at net.minecraft.entity.player.EntityPlayer.func_70636_d(EntityPlayer.java:600) ~[yz.class:?] at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:1611) ~[sv.class:?] at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:288) ~[yz.class:?] at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:295) ~[mw.class:?] at net.minecraft.network.NetHandlerPlayServer.func_147347_a(NetHandlerPlayServer.java:303) ~[nh.class:?] at net.minecraft.network.play.client.C03PacketPlayer.func_148833_a(SourceFile:137) ~[jd.class:?] at net.minecraft.network.play.client.C03PacketPlayer$C06PacketPlayerPosLook.func_148833_a(SourceFile:20) ~[jf.class:?] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) ~[ej.class:?] at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165) ~[nc.class:?] ... 5 more