From bb754ebdeae2f0d6ac785bffe0efad6bbbf63e23 Mon Sep 17 00:00:00 2001
From: Parth Modi <modi.parth152@gmail.com>
Date: Fri, 11 Apr 2025 21:04:28 -0400
Subject: [PATCH] Refactor ExtendedKey structure by removing checksum field and
 updating related tests

---
 lib/extendedkey.ex        | 14 +++++---------
 test/extendedkey_test.exs |  2 --
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/lib/extendedkey.ex b/lib/extendedkey.ex
index a7275c4..0b036c4 100644
--- a/lib/extendedkey.ex
+++ b/lib/extendedkey.ex
@@ -132,8 +132,7 @@ defmodule Bitcoinex.ExtendedKey do
           parent_fingerprint: binary,
           child_num: binary,
           chaincode: binary,
-          key: binary,
-          checksum: binary
+          key: binary
         }
 
   @enforce_keys [
@@ -142,8 +141,7 @@ defmodule Bitcoinex.ExtendedKey do
     :parent_fingerprint,
     :child_num,
     :chaincode,
-    :key,
-    :checksum
+    :key
   ]
 
   defstruct [
@@ -152,8 +150,7 @@ defmodule Bitcoinex.ExtendedKey do
     :parent_fingerprint,
     :child_num,
     :chaincode,
-    :key,
-    :checksum
+    :key
   ]
 
   @xpub_pfx <<0x04, 0x88, 0xB2, 0x1E>>
@@ -253,7 +250,7 @@ defmodule Bitcoinex.ExtendedKey do
         xkey =
           <<prefix::binary-size(4), depth::binary-size(1), parent_fingerprint::binary-size(4),
             child_num::binary-size(4), chaincode::binary-size(32), key::binary-size(33),
-            checksum::binary-size(4)>>
+            _checksum::binary-size(4)>>
       ) do
     cond do
       prefix not in @all_prefixes ->
@@ -276,8 +273,7 @@ defmodule Bitcoinex.ExtendedKey do
                parent_fingerprint: parent_fingerprint,
                child_num: child_num,
                chaincode: chaincode,
-               key: key,
-               checksum: checksum
+               key: key
              }}
         end
     end
diff --git a/test/extendedkey_test.exs b/test/extendedkey_test.exs
index 269320f..ca7835e 100644
--- a/test/extendedkey_test.exs
+++ b/test/extendedkey_test.exs
@@ -33,7 +33,6 @@ defmodule Bitcoinex.Secp256k1.ExtendedKeyTest do
       chaincode:
         <<135, 61, 255, 129, 192, 47, 82, 86, 35, 253, 31, 229, 22, 126, 172, 58, 85, 160, 73,
           222, 61, 49, 75, 180, 46, 226, 39, 255, 237, 55, 213, 8>>,
-      checksum: <<171, 71, 59, 33>>,
       child_num: <<0, 0, 0, 0>>,
       depth: <<0>>,
       key:
@@ -48,7 +47,6 @@ defmodule Bitcoinex.Secp256k1.ExtendedKeyTest do
       chaincode:
         <<135, 61, 255, 129, 192, 47, 82, 86, 35, 253, 31, 229, 22, 126, 172, 58, 85, 160, 73,
           222, 61, 49, 75, 180, 46, 226, 39, 255, 237, 55, 213, 8>>,
-      checksum: <<231, 126, 157, 113>>,
       child_num: <<0, 0, 0, 0>>,
       depth: <<0>>,
       key: