Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Commit a3e993f

Browse files
authored
Merge pull request #2352 from RocketChat/chore/sdk-changes
[RELEASE] 3.4.2
2 parents 62d12ce + e2ae865 commit a3e993f

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ android {
1818
applicationId "chat.rocket.android"
1919
minSdkVersion versions.minSdk
2020
targetSdkVersion versions.targetSdk
21-
versionCode 2069
22-
versionName "3.4.1"
21+
versionCode 2070
22+
versionName "3.4.2"
2323
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2424
multiDexEnabled true
2525

app/src/main/java/chat/rocket/android/db/DatabaseManager.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import chat.rocket.core.internal.model.Subscription
3131
import chat.rocket.core.internal.realtime.socket.model.StreamMessage
3232
import chat.rocket.core.internal.realtime.socket.model.Type
3333
import chat.rocket.core.model.ChatRoom
34+
import chat.rocket.core.model.LastMessage
3435
import chat.rocket.core.model.Message
3536
import chat.rocket.core.model.Myself
3637
import chat.rocket.core.model.Room
@@ -400,8 +401,8 @@ class DatabaseManager(val context: Application, val serverUrl: String, val token
400401
}
401402
}
402403

403-
private fun mapLastMessageText(message: Message?): String? = message?.let { lastMessage ->
404-
if (lastMessage.message.isEmpty() && lastMessage.attachments?.isNotEmpty() == true) {
404+
private fun mapLastMessageText(message: LastMessage?): String? = message?.let { lastMessage ->
405+
if (lastMessage.message?.isEmpty() == true && lastMessage.attachments?.isNotEmpty() == true) {
405406
context.getString(R.string.msg_sent_attachment)
406407
} else {
407408
lastMessage.message

app/src/main/java/chat/rocket/android/server/infrastructure/ConnectionManager.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package chat.rocket.android.server.infrastructure
22

33
import androidx.lifecycle.MutableLiveData
44
import chat.rocket.android.db.DatabaseManager
5+
import chat.rocket.common.model.BaseMessage
56
import chat.rocket.common.model.BaseRoom
67
import chat.rocket.common.model.User
78
import chat.rocket.common.model.UserStatus
@@ -169,7 +170,8 @@ class ConnectionManager(
169170
roomsActor.send(room)
170171
if (room.type != Type.Removed) {
171172
room.data.lastMessage?.let {
172-
messagesActor.send(it)
173+
// FIXME Do we really need to send it to messagesActor?
174+
// messagesActor.send(it as Message)
173175
}
174176
}
175177
}

0 commit comments

Comments
 (0)