Local development based on Docker

[Wirone]

Current development workflow is described in README.md as:

git clone https://github.com/RocketChat/Rocket.Chat.git
cd Rocket.Chat
meteor npm install
meteor npm start

with Git and Meteor as prerequisites.

It does not make sense in modern app development to pollute local machine with dev dependencies (Meteor and NPM packages) and also does not ensure that app is run on the same environment.

Unfortunately docker-compose.yml does not offer local stack based on local code since rocketchat service is run from rocketchat/rocket.chat:latest.

Would be great if there was local development process based on Docker stack, with RocketChat service built from local files, so developer could easily do docker-compose up -d and start the app and work on the code (changes should automatically restart server).

Worth considering:

• Traefik support out of the box with configurable host (label traefik.frontend.rule=Host:${ROCKETCHAT_HOST:-rocketchat.local})
• Support for Docker Host Manager (env DOMAIN_NAME: "default:${ROCKETCHAT_HOST:-rocketchat.local}") (fork because this PR wasn't merged but it's much better to define developer-friendly host rather than default, convention-based hosts)
• mounting local code as volume so node_modules would be stored outside of container and can be easily re-used and changes in code would have immediately effect in the running container
• ignoring all non-app stuff in .dockerignore, such as CI configs
• Makefile with helpful jobs for running app and tests locally
• Docs for building customized production-ready Docker images

[Wirone]

@sampaiodiego @rodrigok could you look at this? Is it something you consider?

[sampaiodiego]

hi @Wirone we have tried to this already a few times without success..

we're definitely accepting contributions on this matter.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Wirone]

@sampaiodiego if you point me where I can find requirements (Node, NPM versions, other dependencies) for running RocketChat, I could try it, but I can't promise anything 🙂

[mrtndwrd]

This is a script I use to build a production docker container:

version=$(meteor npm version | grep 'Rocket.Chat' | egrep -o '[0-9]+.[0-9]+.[0-9]+')
ref=$(git rev-parse --short HEAD)

meteor npm install
meteor build --server-only --directory /tmp/build-pr

cd /tmp/build-pr
cp /home/maarten/projects/github/rocketchat/.docker/Dockerfile .
sudo docker build -t <docker_repo_url>:$version-$ref .

meteor npm install is the command that makes sure all the dependencies are installed. You'll need to install Meteor for it to work of course. The README mentions using meteor npm start instead of meteor build to run the dev environment.

[sampaiodiego]

I have successfully used this Dockerfile to have a running container able to build rocket.chat, but as you can see it clones Rocket.Chat repo to the image, changing this to reading from the host's filesystem might do the trick:

FROM node:12.16.1

VOLUME /tmp/rc-build

# ENV NODE_VERSION 12.16.1
# ENV NODE_ENV production

# OS environment
RUN set -ex \
 && apt update \
 && apt-get install -y build-essential python3.5-dev vim \
 && groupadd -g 65533 -r rocketchat \
 && useradd -u 65533 -r -g rocketchat rocketchat \
 && command -v meteor >/dev/null 2>&1 || curl https://install.meteor.com | sed s/--progress-bar/-sL/g | /bin/sh \
 && mkdir /app \
 && chown rocketchat:rocketchat /app

# User environment
USER rocketchat

ENV HOME /app

WORKDIR /app

RUN export PATH=$HOME/.local/bin:$PATH \
 && curl -O https://bootstrap.pypa.io/get-pip.py \
 && python3.5 get-pip.py --user \
 && pip install awscli --upgrade --user

RUN set -ex \
 && git clone https://github.com/RocketChat/Rocket.Chat.git
#  && cd Rocket.Chat \
#  && meteor --version \
#  && meteor npm i 

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Wirone]

Unfortunately I don't use RocketChat anymore since I've changed company that I'm working with, but personally I think this is basic functionality for contributors, who would like to work with RocketChat, but don't want install all the requirements on their computer. Such setup would also make development consistent between all people (Node version etc.). Please consider giving it higher priority, @sampaiodiego 😉

[mrtndwrd]

As somebody who contributed (once) I wholeheartedly agree wit Wirone that a docker-based setup would make life a lot easier for contributors!

Especially considering that there are pre-push git hooks that can lead to pretty serous headaches (or at least there were when I tried)