From 39939cdab32cec78f17bec2de4f7ac624f1130a2 Mon Sep 17 00:00:00 2001 From: Nathan Sadler Date: Mon, 10 Feb 2025 16:46:44 -0500 Subject: [PATCH 1/3] unmount components added to rails views when removed fromt the DOM --- .../templates/app/javascript/controllers/react_controller.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/generators/rolemodel/react/templates/app/javascript/controllers/react_controller.js b/lib/generators/rolemodel/react/templates/app/javascript/controllers/react_controller.js index 77850441..e3a04da0 100644 --- a/lib/generators/rolemodel/react/templates/app/javascript/controllers/react_controller.js +++ b/lib/generators/rolemodel/react/templates/app/javascript/controllers/react_controller.js @@ -21,4 +21,8 @@ export default class extends Controller { throw new Error('Unrecognized React component name!') } } + + disconnect() { + ReactDOM.unmountComponentAtNode(this.element) + } } From 716b11e5ae5ccd33a621b0222e6c7e82ec7e01b8 Mon Sep 17 00:00:00 2001 From: Nathan Sadler Date: Mon, 10 Feb 2025 16:52:27 -0500 Subject: [PATCH 2/3] update RolemodelRails version number --- lib/rolemodel_rails/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rolemodel_rails/version.rb b/lib/rolemodel_rails/version.rb index 5347309f..9ac828ee 100644 --- a/lib/rolemodel_rails/version.rb +++ b/lib/rolemodel_rails/version.rb @@ -1,3 +1,3 @@ module RolemodelRails - VERSION = '0.12.0' + VERSION = '0.12.1' end From 0779cfdc468be27cfbcd461a1b68f46372adcae6 Mon Sep 17 00:00:00 2001 From: Nathan Sadler Date: Mon, 10 Feb 2025 17:05:30 -0500 Subject: [PATCH 3/3] try unchanging version number --- lib/rolemodel_rails/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rolemodel_rails/version.rb b/lib/rolemodel_rails/version.rb index 9ac828ee..5347309f 100644 --- a/lib/rolemodel_rails/version.rb +++ b/lib/rolemodel_rails/version.rb @@ -1,3 +1,3 @@ module RolemodelRails - VERSION = '0.12.1' + VERSION = '0.12.0' end