Skip to content

api/add-name-to-topology-constraint-group #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ronkahn21 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

api/add-name-to-topology-constraint-group #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85f6b10
feat: add name field to TopologyConstraintGroupConfig
Ronkahn21 Dec 30, 2025
868d06d
feat: add name property to TopologyConstraintGroupConfig
Ronkahn21 Dec 30, 2025
19248dc
feat: add name field to scheduler API documentation for TopologyConst…
Ronkahn21 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/api-reference/scheduler-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `name` _string_ | Name is the name of the topology constraint group.<br />It will drive from the corresponding PCSG name. | | |
| `podGroupNames` _string array_ | PodGroupNames is the list of PodGroup names in the topology constraint group. | | |
| `topologyConstraint` _[TopologyConstraint](#topologyconstraint)_ | TopologyConstraint defines topology packing constraints for this group.<br />Enables PCSG-level topology constraints.<br />Updated by operator when PodCliqueScalingGroup topology constraints change. | | |

Expand Down
3 changes: 3 additions & 0 deletions docs/designs/topology.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,9 @@ type PodGangSpec struct {
```go
// TopologyConstraintGroupConfig defines topology constraints for a group of PodGroups.
type TopologyConstraintGroupConfig struct {
// Name is the name of the topology constraint group.
// It will drive from the corresponding PCSG name.
Name string `json:"name"`
// TopologyConstraint defines topology packing constraints for this group.
// Enables PCSG-level topology constraints.
// Updated by operator when PodCliqueScalingGroup topology constraints change.
Expand Down
6 changes: 6 additions & 0 deletions scheduler/api/core/v1alpha1/crds/scheduler.grove.io_podgangs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ spec:
description: TopologyConstraintGroupConfig defines topology constraints
for a group of PodGroups.
properties:
name:
description: |-
Name is the name of the topology constraint group.
It will drive from the corresponding PCSG name.
type: string
podGroupNames:
description: PodGroupNames is the list of PodGroup names in
the topology constraint group.
Expand Down Expand Up @@ -200,6 +205,7 @@ spec:
type: object
type: object
required:
- name
- podGroupNames
type: object
type: array
Expand Down
3 changes: 3 additions & 0 deletions scheduler/api/core/v1alpha1/podgang.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ type TopologyPackConstraint struct {

// TopologyConstraintGroupConfig defines topology constraints for a group of PodGroups.
type TopologyConstraintGroupConfig struct {
// Name is the name of the topology constraint group.
// It will drive from the corresponding PCSG name.
Name string `json:"name"`
// PodGroupNames is the list of PodGroup names in the topology constraint group.
PodGroupNames []string `json:"podGroupNames"`
// TopologyConstraint defines topology packing constraints for this group.
Expand Down
Loading