Update documentation - GUCs reconfigured at runtime

[amanjeetsingh]

Hi

Can we please either update the documentation and/or add more verbosity to the script along the lines that this script will turn on PQO (and make it the default optimiser) in case it's switched off on a GP database cluster.

Currently, the script enables PQO at the start of the run but leaves it set as the default optimiser once it's done. PQO is not the default optimiser for previous versions of GP (Example - 4.3.10).

Ideally, it would be good that the script switches off the PQO at the end of the run in case it (the script) turned it (PQO) on at runtime.

The script is great and I used it to collect TPC-H benchmarks before we migrate to new GP environment! Thanks.

-Amanjeet

[amanjeetsingh]

Went through the script, and found that the following GUCs are adjusted at runtime. Would be good if we can either update the script to rollback to the original settings at the end of the run or add these to the readme document so that users are aware of these. Thanks.

gpconfig -c optimizer -v on --masteronly
gpconfig -c optimizer_analyze_root_partition -v on --masteronly
gpconfig -c gp_autostats_mode -v none --masteronly
gpconfig -c default_statistics_target -v 100