Database error handling

[elliotblackburn]

I can see in services/dbhandler.js that we are just swallowing errors if the query returns one. The whole db querying seems a bit peculiar for node. Generally we'd make a query which would then have a callback and inside that callback we would then format the response and call the entire operations callback. A bit like below

var pgQuery  = require('pg-query'); // nice wrapper library to pg

function getSomeData(id, callback) {
  var query = 'SELECT * FROM myTable WHERE id=$1';
  var params = [ id ];

  pgQuery(query, params, function(err, rows, results) {
    if(err) {
      return callback(err);
    }
    //Format the results somehow...
    callback(null, results);
  });
}

Then somewhere, updateProfile would be called somewhat like this.

function show(req, res, next) {
  var id = req.params.id;
  db.getSomeData(id, function(err, theData) {
    res.status(200).json(theData);
  }
}

I'm curious as to why we're swallowing errors, is this an oversight or is this done for a reason?

[sis]

There is no reason for this, I'm aware that the database calls can be done better but I never really revisited it after getting it all working at the start + the fact that I was very new to node.

Feel free to improve it!

[elliotblackburn]

That's cool, I was just wondering before I went through and made a few changes to this :) I'll get to work on that so that we can forward errors a bit nicer.

Been looking over things the past few evenings though and it's looking sweet so far.