[BUG]Field Value is not showing up on the hover text of the Billing Country icon on the "Company details" LWC

[mpparimala]

Describe the bug
The "Hover text" on the "Billing Country" icon for "Company details" LWC is not showing correct text. Eg. if the billing country is Canada or CA, the hover text shows "The Country is not US or Canada". Screen shot attached.
Expected to show the field value.

To Reproduce
Steps to reproduce the behavior:

1. Go to Sales->Accounts
2. Click on any account which has "Billing Country" as US or CA
3. Scroll to the right, hover on the LWC "Company details", "CA" icon
4. See error, the hover text shows "The Country is not US or Canada"

Expected behavior
The hover text should retrieve the field value from the "Billing Country" and display.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Browser edge/chrome
• Version [e.g. 22]

Smartphone (please complete the following information):
-not tested

Additional context
If there is any static text entered in the "Hover Text" field in either of the Indicator Item or Indicator Item Extension, it overrides the field value and displays only the static text.
If the "Hover text" field is blank in both indicator item and indicator item extension, in this case, field value is displayed, which seems like a valid usecase.
But in the case of Billing country, we would like to display the static text "The country is not US or Canada" for the other billing countries which conflicts with the above usecase.

[mpparimala]

Hi Jodie,

I was looking at this issue. I came up with a quick fix by just changing some settings in the custom meta data.

I have made the following changes (highlighted in the above screenshot)

1. Created a new "Indicator Item Extension" with priority 22 (so that the condition is checked at the last) to show the hover text "The Country is not US or Canada".
2. Removed the hover text from the Indicator Item, so that it retrieves the field value for other countries.

Below are the test cases tested:

Billing Country => Other than US or CA

Billing Country => US or United States

Billing Country => CA or Canada

Billing Country => Blank or Not entered

As the issue is in production now, will we be able to promote this quick fix to production by just promoting the updated custom metadata changes? Please let me know your comments.

[tschug]

@mpparimala That's a great find and workaround.

I think I've located the actual bug.

In reviewing the code, it appears that Line 258 could be a problem because it's assigning the hover text of the "any field value" or the field's value.

When multiple indicators are to be used (Multi-Select Picklist Mode) It's used on Line 330 and this logic is:

1. If there's a matched extension hover value, use it.
2. Else If there's an "any value" hover text, use it.
3. Else use the field value.

And it should probably just be 1 and 3.

This logic is used for Single Extension Matching Mode on Line 365.

This is the observed bug; that when Lines 312–320 run, it proves that we're assigning the value from the matched extension, but the Hover Text is left null and therefore it's using the 2nd condition of the "Any" Hover Text.

[mpparimala]

Hi Tim @tschug ,

Thanks to your narrowing down the code to the relevant lines, I was able to debug the code and understand the execution flow. I also made the necessary code changes to address the issue. The modified line is highlighted in bold in the code snippet below.

Salesforce-Indicators/force-app/main/default/lwc/indicatorBundle/indicatorBundle.js

Line 316 in ce4e6ac

"HoverValue" : extension.ExtensionHoverText,

The modified logic goes like this, if there is a matched extension, check if the hover text of the matched extension is null, then use fieldValue/datavalue.

if(match) {
// If there is a match for an Extension, assign the extension's override values and these will be used later
matchedExtension = {
"IconName" : extension.ExtensionIconValue,
"TextValue" : extension.ExtensionTextValue,
"ImageUrl" : extension.ExtensionImageUrl,
"HoverValue" : extension.ExtensionHoverText ? extension.ExtensionHoverText : dataValue,
"Priority" : extension.PriorityOrder,
"IconBackground" : extension.BackgroundColor,
"IconForeground" : extension.ForegroundColor
};
....
...
...

I have tested the above code change and it works fine for the basic usecases with different billing country.

Please let me know your comments on this code change and also provide the process, if I need to do more regression testing to test if it affects any other functionality.

Thanks,
Parimala