Update for ModelingToolkit v11 compatibility #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update Project.toml compat to support MTK v10 and v11 - Use __legacy_defaults__ instead of removed defaults keyword in System constructor - Add build_initializeprob=false to ODEProblem calls for MTK v11 compatibility - Update tests to use initial_conditions()/bindings() instead of removed defaults() - Format code with SciMLStyle All 128 tests pass with MTK v11.4.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
Updated to v11-only with proper APIPer feedback, I've updated this PR to:
All 128 tests still pass with MTK v11.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__legacy_defaults__instead of removeddefaultskeyword in System constructor (src/evaluator.jl)build_initializeprob=falseto ODEProblem calls for MTK v11 compatibility (src/BaseModelica.jl)initial_conditions()/bindings()instead of removeddefaults()functionDetails
MTK v11 introduced breaking changes:
defaultskeyword argument toSystemwas removed and replaced withinitial_conditions,bindings, and__legacy_defaults__defaults()accessor function was removedThis PR uses the backwards-compatible
__legacy_defaults__approach to minimize changes while supporting both v10 and v11.Test plan
🤖 Generated with Claude Code