remove checks for versions

Author: TroyKomodo

rust/private/repository_utils.bzl

@@ -656,21 +656,6 @@ def load_llvm_tools(ctx, target_triple, version, iso_date = None):
 
     return BUILD_for_llvm_tools(target_triple), sha256
 
-def check_version_valid(version, iso_date, param_prefix = ""):
-    """Verifies that the provided rust version and iso_date make sense.
-
-    Args:
-        version (str): The rustc version
-        iso_date (str): The rustc nightly version's iso date
-        param_prefix (str, optional): The name of the tool who's version is being checked.
-    """
-
-    if not version and iso_date:
-        fail("{param_prefix}iso_date must be paired with a {param_prefix}version".format(param_prefix = param_prefix))
-
-    if version in ("beta", "nightly") and not iso_date:
-        fail("{param_prefix}iso_date must be specified if version is 'beta' or 'nightly'".format(param_prefix = param_prefix))
-
 def produce_tool_suburl(tool_name, target_triple, version, iso_date = None):
     """Produces a fully qualified Rust tool name for URL
 
@@ -786,7 +771,6 @@ def load_arbitrary_tool(
         Dict[str, str]: A mapping of the tool name to it's sha256 value if the requested tool does not have
             enough information in the repository_ctx to be reproducible.
     """
-    check_version_valid(version, iso_date, param_prefix = tool_name + "_")
 
     # View the indices mentioned in the docstring to find the tool_suburl for a given
     # tool.

rust/repositories.bzl

@@ -20,7 +20,6 @@ load(
     "DEFAULT_NIGHTLY_VERSION",
     "DEFAULT_STATIC_RUST_URL_TEMPLATES",
     "TINYJSON_KWARGS",
-    "check_version_valid",
     "includes_rust_analyzer_proc_macro_srv",
     "load_cargo",
     "load_clippy",
@@ -425,8 +424,6 @@ def _rust_toolchain_tools_repository_impl(ctx):
         version = version_array[0]
         iso_date = version_array[1]
 
-    check_version_valid(ctx.attr.version, iso_date)
-
     exec_triple = triple(ctx.attr.exec_triple)
 
     rustc_content, rustc_sha256 = load_rust_compiler(
@@ -458,14 +455,7 @@ def _rust_toolchain_tools_repository_impl(ctx):
     if ctx.attr.rustfmt_version:
         rustfmt_version = ctx.attr.rustfmt_version
         rustfmt_iso_date = None
-        if rustfmt_version in ("nightly", "beta"):
-            if iso_date:
-                rustfmt_iso_date = iso_date
-            else:
-                fail("`rustfmt_version` does not include an iso_date. The following reposiotry should either set `iso_date` or update `rustfmt_version` to include an iso_date suffix: {}".format(
-                    ctx.name,
-                ))
-        elif rustfmt_version.startswith(("nightly", "beta")):
+        if rustfmt_version.startswith(("nightly/", "beta/")):
             rustfmt_version, _, rustfmt_iso_date = rustfmt_version.partition("/")
         rustfmt_content, rustfmt_sha256 = load_rustfmt(
             ctx = ctx,