-
Notifications
You must be signed in to change notification settings - Fork 481
Open
Description
ShopifyApp::WebhooksManager.add_registrations does not work for those topics.
The topic contain . which is not handled correctly by the ShopifyAPI::Webhooks::Registration. On line 31 '/' is replaced with '_', while '.' is not replaced.
In the ShopifyAPI::Webhooks::Registry service on line 163 both '/' and '.' are replaced.
Expected behavior
Find the webhooks registered on an installed store
Actual behavior
The webhooks are missing with a silent fail
Steps to reproduce the problem
- Add the topics to your required webhooks.
- Install a store
- Check added webhooks
Debug logs
When running the registration for those 2 topics one gets an error in the grapqhl call
"message" => "syntax error, unexpected invalid token (\".\") at [2, 55]",
This is the current graphql mutation, and as one can see the topic is CUSTOMER.TAGS_ADDED instead of CUSTOMER_TAGS_ADDED
"mutation webhookSubscription {\n eventBridgeWebhookSubscriptionCreate(topic: CUSTOMER.TAGS_ADDED, webhookSubscription: {arn: \"arn:aws:events:us-east-1::event-source/aws.partner/shopify.com/3358559/frcpOctavian\"}) {\n userErrors {\n field\n message\n }\n webhookSubscription {\n id\n }\n }\n}\n"
Metadata
Metadata
Assignees
Labels
No labels