December 22, 2023

[aviggiano]

• Added GitHub actions to the CI: run tests, create TypeScript typings, add coverage report to README
• Deployed the contracts with scaffold-eth-2 and tested some basic functionalities. Pros: nice to interact with the contracts. Cons: cumbersome due to the large number of input parameters. It is arguably much easier to play with the contracts on the colab or Solidity unit tests.
  
• Discussed some system properties for the following week's implementations of invariant tests
• Fixed a bug where SOL's credit was not being updated during a SOL exit. Now, both SOLs and FOLs faceValueExited are updated upon exit. Created a regression test to catch that bug.
• Fixed a bug where a SOL was being created with the "exiter" loan as its FOL ID, where not necessarily the "exiting" loan is the FOL. It might be a SOL exiting to a SOL. Created a regression test to catch that bug
  
  
• Implemented "minimum credit" check, which surfaced the bugs above
• Removed lenderExit as it has been superseded by borrowAsMarketOrder
• Roadblocks wrt forge coverage, so the report metrics are misleading bug(forge coverage): stack too deep when using --ir-minimum and coverage report is not accurate foundry-rs/foundry#3357
• We sit at around ~95% coverage, although this is not exact as per the issue above
• Implemented moveToVariablePool
• Implemented borrowerExit
• lendAsMarketOrder tests added
• selfLiquidate tests added