-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
The fetch var in SolidFetchBuilder is allowed to be undefined:
Bashlib/src/authentication/CreateFetch.ts
Line 44 in d4c82f0
| private fetch: undefined | ((input: RequestInfo, init?: RequestInit | undefined) => Promise<Response>); |
This is difficult to work with in typescript, since you need to include checks. However, authenticateToken(options); and authenticateInteractive(options) return a SessionInfo, which does not allow fetch to be undefined.
I was wondering whether
- the methods
buildFromClientCredentialsTokenandbuildInteractivecannot simply return theSessionInfoobject and/or - default to nodefetch when undefined
On a more general note: what's the added-value of the SolidFetchBuilder class to these methods?
Metadata
Metadata
Assignees
Labels
No labels