-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Description
The probe_planar_contour for long NHP Neuropixels probes is incorrectly sized. The polygon height is hardcoded to ~10mm for all NHP probes, regardless of actual probe length.
Affected probes:
- NP1020: contacts span 24,940 μm but contour is only 10,373 μm
- NP1030: contacts span 44,140 μm but contour is only 10,373 μm
The issue is in the polygon_description dictionary which has fixed 10,000 μm heights for all neuropixels variants:
probeinterface/src/probeinterface/neuropixels_tools.py
Lines 93 to 111 in 6b2b819
| def get_probe_length(probe_part_number: str) -> int: | |
| """ | |
| Returns the length of a given probe. We assume a length of | |
| 1cm (10_000 microns) by default. | |
| Parameters | |
| ---------- | |
| probe_part_number : str | |
| The part number of the probe e.g. 'NP2013'. | |
| Returns | |
| ------- | |
| probe_length : int | |
| Length of full probe (microns) | |
| """ | |
| probe_length = 10_000 | |
| return probe_length |
Probably contour should scale with the actual probe length based on contact rows × y_pitch.
This is not capture with the matplotlib version:
https://github.com/SpikeInterface/probeinterface_library/blob/main/imec/NP1020/NP1020.png
Metadata
Metadata
Assignees
Labels
No labels