From 50ba9a9a93514f7ef97027d3666ea8c3574ef7c0 Mon Sep 17 00:00:00 2001 From: MHk | Maros Hauk Date: Tue, 29 Apr 2025 10:46:06 +0200 Subject: [PATCH 1/2] Minor changes to Gemius analytics - removed newProgram for every ad to content transition - removed close event for every ad end --- gemius/CHANGELOG.md | 7 +++++++ gemius/package.json | 2 +- gemius/src/integration/GemiusTHEOIntegration.ts | 3 --- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/gemius/CHANGELOG.md b/gemius/CHANGELOG.md index 5c0e81cb..e548d197 100644 --- a/gemius/CHANGELOG.md +++ b/gemius/CHANGELOG.md @@ -1,5 +1,12 @@ # @theoplayer/gemius-connector-web +## 0.3.1 + +### ✨ Issues + +- removed newProgram for every ad to content transition +- removed close event for every ad end + ## 0.3.0 ### ✨ Features diff --git a/gemius/package.json b/gemius/package.json index 0296ed92..0a0aeb11 100644 --- a/gemius/package.json +++ b/gemius/package.json @@ -1,6 +1,6 @@ { "name": "@theoplayer/gemius-connector-web", - "version": "0.3.0", + "version": "0.3.1", "description": "A connector implementing Gemius with THEOplayer", "main": "dist/gemius-connector.umd.js", "module": "dist/gemius-connector.esm.js", diff --git a/gemius/src/integration/GemiusTHEOIntegration.ts b/gemius/src/integration/GemiusTHEOIntegration.ts index bc7bbb6b..1acf5ed2 100644 --- a/gemius/src/integration/GemiusTHEOIntegration.ts +++ b/gemius/src/integration/GemiusTHEOIntegration.ts @@ -252,8 +252,6 @@ export class GemiusTHEOIntegration { const { adBreak } = event; const { timeOffset } = adBreak; if (!this.isPreRoll(adBreak)) this.partCount++; - const { programID, customAttributes, ...additionalParameters } = this.programParameters; - this.gemiusPlayer.newProgram(programID, { ...additionalParameters, ...customAttributes }); this.player.removeEventListener('playing', this.onFirstPlaying); if (timeOffset === 0) this.player.addEventListener('playing', this.onFirstPlaying); }; @@ -284,7 +282,6 @@ export class GemiusTHEOIntegration { const { timeOffset } = adBreak; const normalizedTimeOffset = this.normalizeTime(timeOffset); this.gemiusPlayer.adEvent(programID, ad.id ?? DEFAULT_AD_ID, normalizedTimeOffset, BasicEvent.COMPLETE); - this.gemiusPlayer.adEvent(programID, ad.id ?? DEFAULT_AD_ID, normalizedTimeOffset, BasicEvent.CLOSE); this.adCount++; this.currentAd = undefined; this.player.removeEventListener('playing', this.onFirstPlaying); From 12792d682efc34d1b17623fc6ecbfc825e5f219a Mon Sep 17 00:00:00 2001 From: MHk | Maros Hauk Date: Tue, 29 Apr 2025 11:45:24 +0200 Subject: [PATCH 2/2] Changeset update --- .changeset/purple-mugs-lie.md | 5 +++++ gemius/CHANGELOG.md | 7 ------- gemius/package.json | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) create mode 100644 .changeset/purple-mugs-lie.md diff --git a/.changeset/purple-mugs-lie.md b/.changeset/purple-mugs-lie.md new file mode 100644 index 00000000..96eea3df --- /dev/null +++ b/.changeset/purple-mugs-lie.md @@ -0,0 +1,5 @@ +--- +"@theoplayer/gemius-connector-web": minor +--- + +Removed unnecessary newProgram/close events diff --git a/gemius/CHANGELOG.md b/gemius/CHANGELOG.md index e548d197..5c0e81cb 100644 --- a/gemius/CHANGELOG.md +++ b/gemius/CHANGELOG.md @@ -1,12 +1,5 @@ # @theoplayer/gemius-connector-web -## 0.3.1 - -### ✨ Issues - -- removed newProgram for every ad to content transition -- removed close event for every ad end - ## 0.3.0 ### ✨ Features diff --git a/gemius/package.json b/gemius/package.json index 0a0aeb11..0296ed92 100644 --- a/gemius/package.json +++ b/gemius/package.json @@ -1,6 +1,6 @@ { "name": "@theoplayer/gemius-connector-web", - "version": "0.3.1", + "version": "0.3.0", "description": "A connector implementing Gemius with THEOplayer", "main": "dist/gemius-connector.umd.js", "module": "dist/gemius-connector.esm.js",