-
Notifications
You must be signed in to change notification settings - Fork 139
Open
Description
It looks like the project currently has two ESLint config files:
Since eslint.config.js follows the new Flat Config format, I think we should stick with that and remove .eslintrc.cjs to avoid confusion.
Would it be safe to delete .eslintrc.cjs?
Minor Suggestions (Optional)
1. GitHub Pages deploy trigger
The current workflow triggers on the master branch, but @telegram-apps/create-mini-app@latest seems to initialize the local git repo with main branch (not master).
push:
- branches: ['master']
+ branches: ['main']here's my full github-pages-deploy.yml file which uses node.js LTS + corepack + pnpm + pnpm deps caching
# Simple workflow for deploying static content to GitHub Pages
name: Deploy static content to Pages
on:
# Runs on pushes targeting the default branch
push:
branches: ["main"]
# Allows to run this workflow manually from the Actions tab
workflow_dispatch:
# Sets the GITHUB_TOKEN permissions to allow deployment to GitHub Pages
permissions:
contents: read
pages: write
id-token: write
# Allow one concurrent deployment
concurrency:
group: "pages"
cancel-in-progress: true
jobs:
# Single deploy job since we're just deploying
deploy:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: "lts/*"
registry-url: "https://registry.npmjs.org"
- name: Enable Corepack
run: corepack enable
- name: Cache pnpm deps
uses: actions/cache@v3
with:
path: |
~/.pnpm-store
node_modules
key: ${{ runner.os }}-pnpm-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-
- name: Install deps
run: pnpm install --frozen-lockfile
- name: Build
run: pnpm build
- name: Setup Pages
uses: actions/configure-pages@v5
- name: Upload artifact
uses: actions/upload-pages-artifact@v3
with:
# Upload dist repository
path: "./dist"
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
Metadata
Metadata
Assignees
Labels
No labels