Build failed because of V8 deprecated API

[chroju]

I have installed this module with node v11.4.0, but failed.

$ node -v
v11.4.0

$ npm install time@0.12

> time@0.12.0 install /home/develop/repos/myhubot/hubot_scripts/node_modules/time
> node-gyp rebuild

make: ディレクトリ `/home/develop/repos/myhubot/hubot_scripts/node_modules/time/build' に入ります
  CXX(target) Release/obj.target/time/src/time.o
../src/time.cc: 静的メンバ関数 ‘static Nan::NAN_METHOD_RETURN_TYPE Time::Localtime(Nan::NAN_METHOD_ARGS_TYPE)’ 内:
../src/time.cc:87:64: 警告: ‘int64_t v8::Value::IntegerValue() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2570): Use maybe version [-Wdeprecated-declarations]
     time_t rawtime = static_cast<time_t>(info[0]->IntegerValue());
                                                                ^
../src/time.cc: 静的メンバ関数 ‘static Nan::NAN_METHOD_RETURN_TYPE Time::Mktime(Nan::NAN_METHOD_ARGS_TYPE)’ 内:
../src/time.cc:141:103: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_sec   = Nan::Get(arg, Nan::New("seconds").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                       ^
../src/time.cc:142:103: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_min   = Nan::Get(arg, Nan::New("minutes").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                       ^
../src/time.cc:143:101: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_hour  = Nan::Get(arg, Nan::New("hours").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                     ^
../src/time.cc:144:106: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_mday  = Nan::Get(arg, Nan::New("dayOfMonth").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                          ^
../src/time.cc:145:101: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_mon   = Nan::Get(arg, Nan::New("month").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                     ^
../src/time.cc:146:100: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_year  = Nan::Get(arg, Nan::New("year").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                    ^
../src/time.cc:147:113: 警告: ‘int32_t v8::Value::Int32Value() const’ は廃止されました (宣言位置 /home/develop/.node-gyp/11.4.0/include/node/v8.h:2572): Use maybe version [-Wdeprecated-declarations]
     tmstr.tm_isdst = Nan::Get(arg, Nan::New("isDaylightSavings").ToLocalChecked()).ToLocalChecked()->Int32Value();
                                                                                                                 ^

Sorry for LANG=ja_JP.UTF-8 . Japanese word "廃止されました" means "deprecated" in English. v8::Value::IntegerValue() and Int32Value() has been removed in V8 7.1.

https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds

[riyadshauk]

I've created a PR #113 which fixes the deprecated V8 API code in time.cc, which gets the package building again.

For the time being, until this repo is fixed, you can use this in your package.json:

  "dependencies": {
    "node-time": "github:riyadshauk/node-time"
  }