Skip to content

Commit 62ab78c

Browse files
authored
Merge pull request #1652 from Areloch/ABAssetPreviewBitmapsFix
Fix for AB Preview Button Bitmaps display
2 parents 55f7b22 + 322d3bb commit 62ab78c

File tree

2 files changed

+40
-52
lines changed

2 files changed

+40
-52
lines changed

Engine/source/gui/buttons/guiIconButtonCtrl.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,10 @@ bool GuiIconButtonCtrl::resize(const Point2I &newPosition, const Point2I &newExt
202202

203203
void GuiIconButtonCtrl::setBitmap(const char *name)
204204
{
205+
_setBitmap(name);
205206
if(!isAwake())
206207
return;
207208

208-
_setBitmap(name);
209-
210209
// So that extent is recalculated if autoSize is set.
211210
resize( getPosition(), getExtent() );
212211

Templates/BaseGame/game/tools/assetBrowser/scripts/assetBrowser.tscript

Lines changed: 39 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,37 @@ function AssetBrowser::buildAssetPreview( %this, %asset, %moduleName )
686686
%tooltip = %assetName;
687687

688688
%textBottomPad = 20;
689+
690+
%previewScaleSize = %this-->previewSlider.getValue();
691+
692+
if(%previewScaleSize $= "")
693+
{
694+
%previewScaleSize = 1;
695+
%this-->previewSlider.setValue(1);
696+
}
697+
698+
if(%this.selectMode)
699+
{
700+
%doubleClickCommand = %this @ ".selectAsset( "@ %this @ ".selectedAsset );";
701+
}
702+
else
703+
{
704+
%doubleClickCommand = %this @ ".callAssetTypeFunc(" @ %assetType @ ", \"onEdit\", \"" @ %moduleName @ "\", \"" @ %assetName @ "\" );";
705+
}
689706

707+
%this.previewData.previewLoaded = true;
708+
709+
//echo("AssetBrowser::buildAssetPreview() - building preview of asset type: " @ %assetType);
710+
%this.callAssetTypeFunc(%assetType, "buildBrowserElement", %moduleName, %assetName, %this.previewData);
711+
712+
//debug dump
713+
%tooltip = %this.previewData.tooltip;
714+
%assetName = %this.previewData.assetName;
715+
%previewImage = %this.previewData.previewImage;
716+
717+
if(%this.previewData.doubleClickCommand !$= "")
718+
%doubleClickCommand = %this.previewData.doubleClickCommand;
719+
690720
%previewButton = new GuiIconButtonCtrl()
691721
{
692722
class = "AssetBrowserPreviewButton";
@@ -699,17 +729,18 @@ function AssetBrowser::buildAssetPreview( %this, %asset, %moduleName )
699729
buttonType = "RadioButton";
700730
buttonMargin = "0 -10";
701731
profile = ToolsGuiDefaultIconBtnProfile;
732+
tooltip = %this.previewData.tooltip;
702733
assetBrowser = %this;
734+
assetName = %assetName;
735+
moduleName = %moduleName;
736+
assetType = %assetType;
737+
bitmapAsset = %this.previewData.previewImage;
738+
Command = %this @ ".updateSelection( $ThisControl.assetName, $ThisControl.moduleName );";
739+
altCommand = %doubleClickCommand;
740+
text = %this.previewData.assetName;
741+
originalAssetName = %this.previewData.assetName;
703742
};
704743

705-
%previewScaleSize = %this-->previewSlider.getValue();
706-
707-
if(%previewScaleSize $= "")
708-
{
709-
%previewScaleSize = 1;
710-
%this-->previewSlider.setValue(1);
711-
}
712-
713744
if(%previewScaleSize == 0 || startsWith(%this.dirHandler.currentAddress, "Creator"))
714745
{
715746
%previewButton.iconLocation = "Left";
@@ -728,48 +759,6 @@ function AssetBrowser::buildAssetPreview( %this, %asset, %moduleName )
728759
%this.previewListMode = false;
729760
}
730761

731-
//%previewButton.extent = %previewSize.x + %previewBounds SPC %previewSize.y + %previewBounds + 24;
732-
%previewButton.assetName = %assetName;
733-
%previewButton.moduleName = %moduleName;
734-
%previewButton.assetType = %assetType;
735-
736-
if(%this.selectMode)
737-
{
738-
%doubleClickCommand = %this @ ".selectAsset( "@ %this @ ".selectedAsset );";
739-
}
740-
else
741-
{
742-
%doubleClickCommand = %this @ ".callAssetTypeFunc(" @ %assetType @ ", \"onEdit\", \"" @ %moduleName @ "\", \"" @ %assetName @ "\" );";
743-
}
744-
745-
%this.previewData.previewLoaded = true;
746-
747-
//echo("AssetBrowser::buildAssetPreview() - building preview of asset type: " @ %assetType);
748-
%this.callAssetTypeFunc(%assetType, "buildBrowserElement", %moduleName, %assetName, %this.previewData);
749-
750-
//debug dump
751-
%tooltip = %this.previewData.tooltip;
752-
%assetName = %this.previewData.assetName;
753-
%previewImage = %this.previewData.previewImage;
754-
755-
if(%this.previewData.doubleClickCommand !$= "")
756-
%doubleClickCommand = %this.previewData.doubleClickCommand;
757-
758-
%previewButton.assetName = %assetName;
759-
%previewButton.moduleName = %moduleName;
760-
%previewButton.assetType = %assetType;
761-
%previewButton.assetBrowser = %this;
762-
763-
%previewButton.setBitmap(%this.previewData.previewImage);
764-
765-
%previewButton.profile = "AssetBrowserPreview" @ %previewButton.assetType;
766-
%previewButton.tooltip = %this.previewData.tooltip;
767-
%previewButton.Command = %this @ ".updateSelection( $ThisControl.assetName, $ThisControl.moduleName );";
768-
%previewButton.altCommand = %doubleClickCommand;
769-
770-
%previewButton.text = %this.previewData.assetName;
771-
%previewButton.text.originalAssetName = %this.previewData.assetName;
772-
773762
// add to the gui control array
774763
%this-->assetList.add(%previewButton);
775764

0 commit comments

Comments
 (0)