-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Description
Several components use hardcoded #fff color values instead of the semantic theme.white from ThemeContext. This violates the theming guidelines in CLAUDE.md which states:
Use semantic colors from ThemeContext, never raw Palette colors
Files Affected
-
components/program/DayDetailSheet.tsx
- Line 66:
- Line 173: color: '#fff' in styles
-
components/program/LogMeetingSheet.tsx
- Line 246: color="#fff"
- Line 489: color: '#fff'
-
components/program/MeetingsCalendar.tsx
- Line 221: color: '#fff'
-
components/whats-new/WhatsNewVersionSection.tsx
- Line 223: color: '#ffffff'
- Line 235: color: '#ffffff'
-
components/whats-new/WhatsNewFeatureCard.tsx
- Line 35: Hardcoded skeleton background color
- Lines 51, 58: TYPE_CONFIG with hardcoded green/purple colors
Recommended Fix
Replace all #fff / #ffffff with theme.white using the theme from useTheme() hook.
For WhatsNewFeatureCard TYPE_CONFIG, consider:
- Moving type colors to the theme system, or
- Creating semantic constants if these are intentionally fixed brand colors
Priority
Low - cosmetic consistency issue, no functional impact
Related
- CLAUDE.md theming guidelines
- 📋 Daily Codebase Review - 2026-02-04 #377 Daily Codebase Review
Generated by automated codebase review
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels