Skip to content

Games not being added to WiiMixGlobalSettings on launch #2

@gyoder

Description

@gyoder

In WiiMixGlobalSettings::AddGame inGlobalSettings.cpp, the call to Core::IsRunning(Core::System::GetInstance()) returns true on Dolphin startup, bypassing adding games to the settings singleton. I have no idea what is causing this.

void WiiMixGlobalSettings::AddGame(const std::shared_ptr<const UICommon::GameFile>& game) {
    // Only make changes if the system is not running or starting
    if (Core::IsRunning(Core::System::GetInstance())) // TODOx: something is wrong with this. it should not be true. changed for testing
        return;

    m_games.push_back(game);

    // NOTE: the GUI does not need to be rebuilt here because the game tracker in GameListModel emits a signal to build the GUI already
    // This is just also connected to that signal to have the data all in one place
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions