Skip to content

Commit 8b86edf

Browse files
committed
Remove debug logging - bug is fixed (v1.0.18)
The debug logging in v1.0.17 confirmed the fix works. Removing the console.error statements as they're no longer needed. The actual fix was the combination of all previous changes: - v1.0.11: Explicit isLoading: false in applyFetchedLevel overrides - v1.0.14: Silent fetch activeQueryId fix - v1.0.15: Coalescing invariant fix - v1.0.16: Removed race condition sync Version: 1.0.17 → 1.0.18
1 parent 23cf9ca commit 8b86edf

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "verity-dl",
3-
"version": "1.0.17",
3+
"version": "1.0.18",
44
"description": "A framework agnostic data layer built to handle the communication layer between the server and the client seamlessly and keep the ui state always up to date with the source of truth",
55
"main": "verity/shared/static/lib/core.js",
66
"module": "verity/shared/static/lib/core.js",

verity/shared/static/lib/core.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,21 +1296,6 @@ function applyFetchedLevel(T, typeName, id, ref, sourceLevelKey, data, timestamp
12961296
isLoading: false, // Fetch completed successfully, clear loading state
12971297
};
12981298
const nextMeta = finalizeItemMeta(ref, sourceLevelKey, qid, overrides, options);
1299-
1300-
// Debug logging
1301-
if (nextMeta.isLoading === true) {
1302-
console.error('[VERITY BUG] finalizeItemMeta returned isLoading=true after fetch completed!', {
1303-
typeName,
1304-
id,
1305-
sourceLevelKey,
1306-
qid,
1307-
'ref.meta.activeQueryId': ref.meta.activeQueryId,
1308-
'ref.meta.isLoading': ref.meta.isLoading,
1309-
'nextMeta.isLoading': nextMeta.isLoading,
1310-
'nextMeta.activeQueryId': nextMeta.activeQueryId,
1311-
overrides
1312-
});
1313-
}
13141299

13151300
assignRef(ref, { data: nextData, meta: nextMeta });
13161301
}

0 commit comments

Comments
 (0)